[
https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718799#comment-16718799
]
ASF GitHub Bot commented on S2GRAPH-248:
GitHub user daewon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/193
[S2GRAPH-248] HTTP interface integration.
Work to resolve this issue.
1. Crete s2http project and migrate functions (from s2rest_play)
2. Remove the http layer from s2graphql project and integrate into s2http
3. Set default startup script to use s2http on package.
Todo: migrate s2rest_play tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daewon/incubator-s2graph S2GRAPH-248
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/193.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #193
commit a16ecb08819ea01f4498dfdd371717de56387a72
Author: daewon
Date: 2018-11-26T08:11:36Z
s2http initial commit
commit 4154bbe1605a1fc7f4b8cae6fda71ecf8b317319
Author: daewon
Date: 2018-11-28T04:51:43Z
add PlayJsonSupport
commit b8ab86dd39fd3810afcf44160324fa2dc6f5ee3f
Author: DO YUNG YOON
Date: 2018-11-29T01:51:20Z
merge S2GRAPH-249
commit 1dda954d3c07ddb0966546501c3078c67e2cbc04
Author: daewon
Date: 2018-11-29T08:16:24Z
Merge pull request #3 from SteamShon/S2GRAPH-248
@SteamShon Thanks for your work.!
merge [S2GRAPH-249]
commit f41ab569345e9180e8f66355422bbeb7548f0670
Author: daewon
Date: 2018-11-29T09:55:39Z
merge S2GRAPH-249
commit dcaa1f34c4dd9bba863d5e532b9b0893e6b9a287
Author: daewon
Date: 2018-11-30T07:46:03Z
add graphql route in s2http
commit ac630bf68c777fe963f1beaba90d7989fe755e4f
Author: daewon
Date: 2018-12-12T10:47:31Z
Change startup script project to s2http
> HTTP interface integration.
> ---
>
> Key: S2GRAPH-248
> URL: https://issues.apache.org/jira/browse/S2GRAPH-248
> Project: S2Graph
> Issue Type: Task
> Components: s2core, s2rest_netty, s2rest_play
>Reporter: Daewon Jeong
>Priority: Minor
>
> The current HTTP interface in S2Graph has the following problems.
> known issues:
> 1. The `s2rest_netty` project is experimental and supports only `graph
> traverse` API.
> 2. `s2rest_play` based on Play! Framework.
> - Play! Framework is full stack framework, so it has a lot of
> dependencies that s2graph does not need.
> - There is also a conflict with byte buddy for patching asynchbase.
> 3. `GraphQL` is still in the experimental phase and does not yet provide
> all the functionality.
> The discussion below is written on the link below.
> discussions:
> [https://lists.apache.org/thread.html/56379268a12ed5e64a2d7497a8741b09cdf2194bf7a3c303000420b6@%3Cdev.s2graph.apache.org%3E]
>
> Based on this issue, the following work should be done.
> * Create an HTTP interface project(without play!)
> * Remove s2rest_netty
> * API documentation (GraphQL, Rest)
> * GraphQL and Rest HTTP interface integration
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)