[jira] [Commented] (S2GRAPH-8) Update readme for project structure refactoring

2016-01-19 Thread Hyunsung Jo (JIRA)

[ 
https://issues.apache.org/jira/browse/S2GRAPH-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106466#comment-15106466
 ] 

Hyunsung Jo commented on S2GRAPH-8:
---

[~steamshon]
Isn't this a duplicate of S2GRAPH-2?

> Update readme for project structure refactoring
> ---
>
> Key: S2GRAPH-8
> URL: https://issues.apache.org/jira/browse/S2GRAPH-8
> Project: S2Graph
>  Issue Type: Sub-task
>Reporter: DOYUNG YOON
>Assignee: Daewon Jeong
>Priority: Minor
>  Labels: document, refactoring
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> readme should follow up project structure refactoring.
> for example, previously "sbt test" would run tests on rest server. after 
> refactoring this should be changed to specify project to run test(something 
> like "sbt 'project s2rest_xxx' test")



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (S2GRAPH-2) Update document and quick start environment to have recent set-up command changes

2016-01-19 Thread Hyunsung Jo (JIRA)

[ 
https://issues.apache.org/jira/browse/S2GRAPH-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106465#comment-15106465
 ] 

Hyunsung Jo commented on S2GRAPH-2:
---

[~wishoping]

You are correct, no change required in {{schema.sql}}.
I meant that the [Getting 
Started|https://steamshon.gitbooks.io/s2graph-book/content/getting_started.html]
 document had to be updated in order to remove redundancy.
(It contained instructions on setting up MySQL user and access rights which is 
now part of the SQL script itself. Anyway, the document was updated a while 
ago, so no problems.)


> Update document and quick start environment to have recent set-up command 
> changes
> -
>
> Key: S2GRAPH-2
> URL: https://issues.apache.org/jira/browse/S2GRAPH-2
> Project: S2Graph
>  Issue Type: Task
>Reporter: Hyunsung Jo
>Priority: Minor
>  Labels: documentation
>
> Due to refactoring, the start-up command for S2Graph has changed.
> bq. sbt run => activator 'project s2rest_play' run
> Apply this to documentation.
> Also, {{schema.sql}} now includes user and access rights.
> This part should be removed from the manual. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (S2GRAPH-18) Query Option "interval" is Broken

2016-01-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/S2GRAPH-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106622#comment-15106622
 ] 

ASF GitHub Bot commented on S2GRAPH-18:
---

Github user HyunsungJo commented on the pull request:

https://github.com/apache/incubator-s2graph/pull/9#issuecomment-172826276
  
:bow: 


> Query Option "interval" is Broken
> -
>
> Key: S2GRAPH-18
> URL: https://issues.apache.org/jira/browse/S2GRAPH-18
> Project: S2Graph
>  Issue Type: Bug
>Reporter: Hyunsung Jo
>Assignee: Daewon Jeong
>
> *Problem*
> The {{interval}} option doesn't seem to work on secondary indices.
> *Steps to Reproduce Issue*
> 1. Create service.
>   {noformat}
>   curl -XPOST localhost:9000/graphs/createService -H 'Content-Type: 
> Application/json' -d '
>   {
> "serviceName": "interval",
> "hTableName": "interval-dev"
>   }
>   '
>   {noformat}
> 2. Create label with more than multiple indices.
>   {noformat}
>   curl -XPOST localhost:9000/graphs/createLabel -H 'Content-Type: 
> Application/json' -d '
>   {
> "label": "interval_test",
> "srcServiceName": "interval",
> "srcColumnName": "ad_id",
> "srcColumnType": "string",
> "tgtServiceName": "interval",
> "tgtColumnName": "url",
> "tgtColumnType": "string",
>   "isDirected": "true",
>   "indices": [
>   {
>   "name": "_PK",
>   "propNames": [
>   "_timestamp"
>   ]
>   },
>   {
>   "name": "IDX_ACTION_TYPE",
>   "propNames": [
>   "actionType",
>   "_timestamp"
>   ]
>   }
>   ],
>   "props": [
>   {
>   "name": "serviceName",
>   "defaultValue": "",
>   "dataType": "string"
>   },
>   {
>   "name": "actionType",
>   "defaultValue": "",
>   "dataType": "string"
>   }
>   ],
>   "consistencyLevel": "strong"
>   }
>   '
>   {noformat}
> 3. Insert test data.
>   {noformat}
>   curl -XPOST -H 'Content-Type: application/json' 
> localhost:9000/graphs/edges/insert -d '
>   [
>  {
>  "from": "jojo",
>  "to": "www.kakaocorp.com",
>  "label": "interval_test",
>  "props": {"serviceName": "talk-scrap", "actionType": "share"},
>  "timestamp": 1433495457557
>  }
>   ]
>   '
>   {noformat}
> 4. Query with interval on primary index. => This works! (edge returned)
>   {noformat}
>   curl -XPOST localhost:9000/graphs/getEdges -H 'Content-type: 
> Application/json' -d '
>   {
>   "srcVertices": [
>   {
>   "serviceName": "interval",
>   "columnName": "ad_id",
>   "id": "jojo"
>   }
>   ],
>   "steps": [
>   {
>   "step": [
>   {
>   "label": "interval_test",
>   "index": "_PK",
>   "interval": {
>   "from": [
>   {
>   "_timestamp": 1433495457556
>   }
>   ],
>   "to": [
>   {
>   "_timestamp": 1433495457558
>   }
>   ]
>   }
>   }
>   ]
>   }
>   ]
>   }
>   '
>   {noformat}
> 5. Query with interval on secondary index. => Doesn't work!! (empty result..)
>   {noformat}
>   curl -XPOST localhost:9000/graphs/getEdges -H 'Content-type: 
> Application/json' -d '
>   {
>   "srcVertices": [
>   {
>   "serviceName": "interval",
>   "columnName": "ad_id",
>   "id": "jojo"
>   }
>   ],
>   "steps": [
>   {
>   "step": [
>   {
>   "label": "interval_test",
>   "index": "IDX_ACTION_TYPE",
>   "interval": {
>   "from": [
>   {
>   "actionType": "share"
>   }
>   ],
>   "to": [
>   {
>   "actionType": "share"
>   }
>   ]
>   }
>   }
>   ]
>   }
>   ]
>   }
>   '
>   {noformat}
> *Cause of Issue*
> The function {{interval()}} in {{QueryParam.scala}} uses {{labelOrderSeq}} 
> witch is currently not set at time of function call. In function 
> {{parseQueryParam()}} of {{RequestParser.scala}}, {{.interval(interval)}} 
> should come after {{.labelOrderSeq(indexSeq)}}.



--
This message was sent by Atlassian