[jira] [Commented] (S2GRAPH-203) Support "application/graphql" Content-Type header
[ https://issues.apache.org/jira/browse/S2GRAPH-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515406#comment-16515406 ] ASF GitHub Bot commented on S2GRAPH-203: Github user asfgit closed the pull request at: https://github.com/apache/incubator-s2graph/pull/172 > Support "application/graphql" Content-Type header > - > > Key: S2GRAPH-203 > URL: https://issues.apache.org/jira/browse/S2GRAPH-203 > Project: S2Graph > Issue Type: Improvement > Components: s2graphql >Reporter: Chul Kang >Assignee: Daewon Jeong >Priority: Minor > > When sending a post request with GraphQL with "application/json" > Content-Type, it needs to escape GraphQL to string. > I think if we support the "application/graphql" Conetent-Type, we could use > GraphQL without escaping. > http://graphql.org/learn/serving-over-http/#post-request -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (S2GRAPH-219) Added query that includes all vertices and associated edges for GraphVisualize.
[
https://issues.apache.org/jira/browse/S2GRAPH-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515384#comment-16515384
]
ASF GitHub Bot commented on S2GRAPH-219:
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-s2graph/pull/170
> Added query that includes all vertices and associated edges for
> GraphVisualize.
> ---
>
> Key: S2GRAPH-219
> URL: https://issues.apache.org/jira/browse/S2GRAPH-219
> Project: S2Graph
> Issue Type: New Feature
> Components: s2graphql
>Reporter: Daewon Jeong
>Assignee: Daewon Jeong
>Priority: Minor
>
> h1. Supports result format for GraphVisualize.
> The query result of S2Graph is suitable for checking connected data.
> However, such as [sigma.js|http://sigmajs.org/], the Grpah drawing tool must
> process the results to use it.
> Connecting all vertices and edges is a complex and tedious task.
> Therefore, supports the result format which is easy to use in Graph Tools
> like the [sigma.js|http://sigmajs.org/].
> [sigma.js|http://sigmajs.org/] requires the following form.
> {code:json}
> {
> "nodes": [
> {
> "id": "n0",
> "label": "A node",
> "x": 0,
> "y": 0,
> "size": 3
> },
> {
> "id": "n1",
> "label": "Another node",
> "x": 3,
> "y": 1,
> "size": 2
> },
> {
> "id": "n2",
> "label": "And a last one",
> "x": 1,
> "y": 3,
> "size": 1
> }
> ],
> "edges": [
> {
> "id": "e0",
> "source": "n0",
> "target": "n1"
> },
> {
> "id": "e1",
> "source": "n1",
> "target": "n2"
> },
> {
> "id": "e2",
> "source": "n2",
> "target": "n0"
> }
> ]
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (S2GRAPH-222) Support Not logical operator in WhereParser.
[
https://issues.apache.org/jira/browse/S2GRAPH-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515371#comment-16515371
]
Daewon Jeong commented on S2GRAPH-222:
--
[~steamshon]
I agree with the addition of the Like statement.
But so far, it's a good idea to separate it into separate issues.
The current issue (S2GRAPH-222) is that it is better to limit the scope to what
is now implemented.
> Support Not logical operator in WhereParser.
> -
>
> Key: S2GRAPH-222
> URL: https://issues.apache.org/jira/browse/S2GRAPH-222
> Project: S2Graph
> Issue Type: New Feature
> Components: s2core
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
>Priority: Minor
>
> `And/Or` operator is implemented as a logical operator, but `Not` is not
> implemented in WhereParser.
> This is illustrated by following examples.
> Following query works only because we added hardcoded implementation on `not
> in` as predicates.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "friend_name not in ('steamshon')") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> I believe implementing `Not` as a logical operator is more general, so below
> is my suggestion.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "NOT (friend_name in ('steamshon'))") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> In this way, we don't need to implement not case for all predicates, such as
> `in`, `between`, `contains`, `eq`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (S2GRAPH-221) Unify configurations for bulk and mutate in S2GraphSink.
[ https://issues.apache.org/jira/browse/S2GRAPH-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515321#comment-16515321 ] DOYUNG YOON commented on S2GRAPH-221: - [~elric] Can you please review this? > Unify configurations for bulk and mutate in S2GraphSink. > > > Key: S2GRAPH-221 > URL: https://issues.apache.org/jira/browse/S2GRAPH-221 > Project: S2Graph > Issue Type: Improvement > Components: s2jobs >Reporter: DOYUNG YOON >Assignee: DOYUNG YOON >Priority: Minor > > Currently, S2GraphSink in s2jobs provide two way to sink data from spark into > S2Graph. > 1. mutate: open S2Graph per each executor, then call mutateElements method. > 2. bulk: run spark job to build HFile and run loadIncrementalHFiles. > It is hard to followup options for these two different method, since mutate > options are defined in org.apache.s2graph.spark.sql.streaming.S2SinkConfigs, > and bulkload options are defined in > org.apache.s2graph.s2jobs.load.GraphFileOptions. > I suggest placing all configurations under in one place so it would be easy > to maintain them. > Also, many options for bulk can be removed. > One example is dbUrl options, which is same as "db.default.url" and zkQuorum, > which is same as "hbase.zookeeper.quorum". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (S2GRAPH-222) Support Not logical operator in WhereParser.
[
https://issues.apache.org/jira/browse/S2GRAPH-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515280#comment-16515280
]
DOYUNG YOON commented on S2GRAPH-222:
-
[~daewon]
Thanks for your feedback. I agree that `NOT condidtion` clauses can be useful.
I think I need to revert last commit that remove 'not in' clause, but other
than that it seems like provide 'like' and 'not like' also.
I believe 'like' is implemented as `Contain` Clause class but use different
grammar.
I am wondering if you are suggesting adding `Like` and `NOT Like`(which I vote
for +1)?
> Support Not logical operator in WhereParser.
> -
>
> Key: S2GRAPH-222
> URL: https://issues.apache.org/jira/browse/S2GRAPH-222
> Project: S2Graph
> Issue Type: New Feature
> Components: s2core
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
>Priority: Minor
>
> `And/Or` operator is implemented as a logical operator, but `Not` is not
> implemented in WhereParser.
> This is illustrated by following examples.
> Following query works only because we added hardcoded implementation on `not
> in` as predicates.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "friend_name not in ('steamshon')") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> I believe implementing `Not` as a logical operator is more general, so below
> is my suggestion.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "NOT (friend_name in ('steamshon'))") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> In this way, we don't need to implement not case for all predicates, such as
> `in`, `between`, `contains`, `eq`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (S2GRAPH-223) Support WhereParser on Vertex.
[
https://issues.apache.org/jira/browse/S2GRAPH-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515279#comment-16515279
]
DOYUNG YOON commented on S2GRAPH-223:
-
[~daewon] Appreciate it!
> Support WhereParser on Vertex.
> --
>
> Key: S2GRAPH-223
> URL: https://issues.apache.org/jira/browse/S2GRAPH-223
> Project: S2Graph
> Issue Type: New Feature
> Components: s2core
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
>Priority: Major
>
> Currently, WhereParser is only available for Edge so it is not possible to
> filter vertex with predicates.
> One example query would look like followings.
> {noformat}
> query {
> s2graph {
> User(id: 1, filter: "name contains 'steamshon'") {
> id
> }
> }
> }
> {noformat}
> I suggest to add vertex support in WhereParser, so GraphQL query can also
> benefit from WhereParser.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
