[jira] [Commented] (S2GRAPH-203) Support "application/graphql" Content-Type header
[ https://issues.apache.org/jira/browse/S2GRAPH-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515406#comment-16515406 ] ASF GitHub Bot commented on S2GRAPH-203: Github user asfgit closed the pull request at: https://github.com/apache/incubator-s2graph/pull/172 > Support "application/graphql" Content-Type header > - > > Key: S2GRAPH-203 > URL: https://issues.apache.org/jira/browse/S2GRAPH-203 > Project: S2Graph > Issue Type: Improvement > Components: s2graphql >Reporter: Chul Kang >Assignee: Daewon Jeong >Priority: Minor > > When sending a post request with GraphQL with "application/json" > Content-Type, it needs to escape GraphQL to string. > I think if we support the "application/graphql" Conetent-Type, we could use > GraphQL without escaping. > http://graphql.org/learn/serving-over-http/#post-request -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (S2GRAPH-203) Support "application/graphql" Content-Type header
[
https://issues.apache.org/jira/browse/S2GRAPH-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512212#comment-16512212
]
ASF GitHub Bot commented on S2GRAPH-203:
GitHub user daewon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/172
[S2GRAPH-203] Support "application/graphql" Content-Type header
I added the ability to allow the GraphQL server to interpret the
`application/graphql` content-type.
no longer need to escape the `graphql query string` to a `json string`
example)
```bash
curl --request POST \
--url http://localhost:8000/graphql \
--header 'content-type: application/graphql' \
--data 'query Welcome {
kakao {
user(id: "daewon") {
id
}
}
}'
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daewon/incubator-s2graph S2GRAPH-203
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #172
commit 23a22775173b1e5d71124fdddcda7c96d8fb4927
Author: daewon
Date: 2018-06-14T09:08:42Z
add content-type: application/graphql
> Support "application/graphql" Content-Type header
> -
>
> Key: S2GRAPH-203
> URL: https://issues.apache.org/jira/browse/S2GRAPH-203
> Project: S2Graph
> Issue Type: Improvement
> Components: s2graphql
>Reporter: Chul Kang
>Assignee: Daewon Jeong
>Priority: Minor
>
> When sending a post request with GraphQL with "application/json"
> Content-Type, it needs to escape GraphQL to string.
> I think if we support the "application/graphql" Conetent-Type, we could use
> GraphQL without escaping.
> http://graphql.org/learn/serving-over-http/#post-request
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (S2GRAPH-203) Support "application/graphql" Content-Type header
[ https://issues.apache.org/jira/browse/S2GRAPH-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432017#comment-16432017 ] Daewon Jeong commented on S2GRAPH-203: -- [~chul] Thank you for your good suggestion. I will implement it by referring to the site and link below. [https://github.com/sangria-graphql/sangria-akka-http-example|http://example.com] > Support "application/graphql" Content-Type header > - > > Key: S2GRAPH-203 > URL: https://issues.apache.org/jira/browse/S2GRAPH-203 > Project: S2Graph > Issue Type: Improvement > Components: s2graphql >Reporter: Chul Kang >Assignee: Daewon Jeong >Priority: Minor > > When sending a post request with GraphQL with "application/json" > Content-Type, it needs to escape GraphQL to string. > I think if we support the "application/graphql" Conetent-Type, we could use > GraphQL without escaping. > http://graphql.org/learn/serving-over-http/#post-request -- This message was sent by Atlassian JIRA (v7.6.3#76005)
