[ https://issues.apache.org/jira/browse/S2GRAPH-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325871#comment-15325871 ]
ASF GitHub Bot commented on S2GRAPH-66: --------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/incubator-s2graph/pull/50 > Optimize toEdge, IndexEdgeDeserializable using mutable Map. > ----------------------------------------------------------- > > Key: S2GRAPH-66 > URL: https://issues.apache.org/jira/browse/S2GRAPH-66 > Project: S2Graph > Issue Type: Improvement > Reporter: DOYUNG YOON > Assignee: DOYUNG YOON > Labels: serde, write > Fix For: 0.1.0 > > Original Estimate: 168h > Remaining Estimate: 168h > > since {{Storage#toEdge}} is called lots of times(# of edges query traverse), > I think it is worth to optimize futher. > based on profile, we can notice that List#toMap and List#++ on two list takes > many cpu time on toEdge(actually {{IndexEdgeDeserializable#fromKeyValues}}). > we can avoid List#toMap and List#++ by using MapBuilder and give up > functional style here. > I think code looks ugly(maybe not), but we can remove unnecessary cpu usage. > !https://cloud.githubusercontent.com/assets/1264825/14624064/2659ab3e-0612-11e6-9c94-37d866bcda93.jpg! -- This message was sent by Atlassian JIRA (v6.3.4#6332)