Re: Including asynchbase in the sourcetree

Hi, Jong Wook. 1. Good point. I think we set column family when create GetRequest( https://github.com/apache/incubator-s2graph/blob/master/s2core/src/main/scala/org/apache/s2graph/core/storage/hbase/AsynchbaseStorage.scala#L249) and Scanner(

Re: Including asynchbase in the sourcetree

Hi Jong Wook. Thanks for casting this issue and working on it. I took some time today, to clear the custom patches and find out followings. 1. GetRequest.setMaxResultsPerColumnFamily/setRowOffsetPerColumnFamily methods. I think we do not actually need this method which only exist on our custom

Re: Including asynchbase in the sourcetree

I managed to created a version using ASM and ByteBuddy to do the patchwork: https://github.com/jongwook/incubator-s2graph/commit/770917e0c05228ba0855c16e417436bcc67ff412 . It does: - Use ASM to

Re: Including asynchbase in the sourcetree

That would be ideal, but asynchbase is being developed according to OpenTSDB’s own schedules that we don’t have control over. They don’t release snapshot artifacts and we needed to make a custom artifact anyway, and given the fact that their releases are usually only once a year I’m not sure

Re: Including asynchbase in the sourcetree

As far as I understood, such changes affect mainly configuration (timeouts, limits, offsets, etc), right? Would not be better to submit a PR to the upstream project to allow to customize such configurations without modifying the code? On Tue, Sep 27, 2016 at 8:49 AM, Jong Wook Kim

Including asynchbase in the sourcetree

Related to the recent comments raised in the vote thread, I’d like to revisit the asynchbase issue. Now their fixes on NSRE are tagged in the recently fixed 1.7.2 on Maven Central, the remaining differences between our custom version and the official version are: - RPC-wise timeout setting in