Re: Review Request 39252: SAMZA-626 - tool to read the RocksDb in a running job (Yan's patch)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39252/ --- (Updated Oct. 23, 2015, 11:46 p.m.) Review request for samza, Yan Fang, Chinmay

Re: Review Request 39252: SAMZA-626 - tool to read the RocksDb in a running job (Yan's patch)

> On Oct. 23, 2015, 1:22 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/java/org/apache/samza/config/JavaSerializerConfig.java, > > line 1 > > > > > > I noticed that we are creating new JavaSerializ

Re: Review Request 39464: SAMZA-723 - hello-samza hangs when we use StreamAppender (Yan's patch)

> On Oct. 23, 2015, 8:02 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java, > > line 205 > > > > > > This is also one of my concern when I was

Re: Review Request 39464: SAMZA-723 - hello-samza hangs when we use StreamAppender (Yan's patch)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39464/#review103842 --- samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamApp

Re: Review Request 39464: SAMZA-723 - hello-samza hangs when we use StreamAppender (Yan's patch)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39464/#review103838 --- Ship it! LGTM. Thanks! samza-log4j/src/main/java/org/apache/samz

Re: Review Request 39252: SAMZA-626 - tool to read the RocksDb in a running job (Yan's patch)

> On Oct. 23, 2015, 1:22 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-kv-rocksdb/src/main/java/org/apache/samza/storage/kv/RocksDbKeyValueStoreHelper.java, > > line 34 > > > > > > nit: maybe rename to RocksDbO

Re: Review Request 39558: Fix parsing errors in broadcast stream config values

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39558/#review103768 --- Ship it! lgtm - Jagadish Venkatraman On Oct. 22, 2015, 5:12 p.m