Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

2015-10-30 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39806/ --- Review request for samza, Chris Riccomini, Jake Maes, Jagadish Venkatraman, and

Re: Checkpoint tool not working

2015-10-30 Thread Navina Ramesh
Hi Lucas, What is the format that you are using for re-specifying the offsets? Do you specify it with --new-offsets ? If you can share that, it will be great. It seems to work for me. Thanks! Navina On Fri, Oct 30, 2015 at 9:11 AM, Roger Hoover wrote: > I tried it

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

2015-10-30 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39806/ --- (Updated Oct. 30, 2015, 10:49 p.m.) Review request for samza, Chris Riccomini,

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

2015-10-30 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39806/ --- (Updated Oct. 30, 2015, 8:53 p.m.) Review request for samza, Chris Riccomini,

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

2015-10-30 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39806/ --- (Updated Oct. 31, 2015, 1:24 a.m.) Review request for samza, Chris Riccomini,

Re: Checkpoint tool not working

2015-10-30 Thread Roger Hoover
I tried it once with 0.9.1 and it didn't work for me either. I didn't have time to examine it more carefully at the time. Roger On Thu, Oct 29, 2015 at 10:05 PM, Lukas Steiblys wrote: > I'm using Samza 0.9.1. > > Lukas > > On 10/29/15, Yi Pan wrote:

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

2015-10-30 Thread Navina Ramesh
> On Oct. 30, 2015, 6:06 p.m., Xinyu Liu wrote: > > samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointManager.java, > > line 29 > > > > > > Just a nitpick: for java interfaces, all methods are public, so

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

2015-10-30 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39806/#review104583 --- Ship it! Some minor suggestions. Overall the change looks good.