Re: Passing Java system properties to YARN containers of Samza Job

2015-12-09 Thread Tommy Becker
You should also prefix the names of the API keys with "sensitive.". This will mask the values when the config is logged and in the AM UI. On 12/09/2015 01:19 AM, Yi Pan wrote: Hi, Gordon, Try to use --config X.Y.Z=value from the command line to run run-job.sh On Tue, Dec 8, 2015 at 5:57 PM,

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

2015-12-09 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41106/#review109571 --- Ship it!

Re: [VOTE] Samza 0.10.0 Release Candidate 2

2015-12-09 Thread xinyu liu
+1 on my side. I also ran the gradle build and unit tests without failure. Thanks, Xinyu On Wed, Dec 9, 2015 at 9:54 AM, Tao Feng wrote: > +1 from my side(non-binding). I download the package and successfully run > all the unit tests without failure. > > On Tue, Dec 8,

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

2015-12-09 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41106/#review109619 --- Ship it! - Boris Shkolnik On Dec. 9, 2015, 6:41 a.m., Tao Feng

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

2015-12-09 Thread Tao Feng
> On Dec. 9, 2015, 6:06 p.m., Jake Maes wrote: > > samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala, > > line 38 > > > > > > nit: this message will no longer be valid after we fully

Re: Passing Java system properties to YARN containers of Samza Job

2015-12-09 Thread Boris Shkolnik
I am not sure about AWS credentials, but, in general, you can use task.opts config value to pass any java level settings, which will be passed to each container jvm. On Tue, Dec 8, 2015 at 9:57 AM, Gordon Tai wrote: > Hi, > > Is there any convenient way to pass custom Java

Re: [VOTE] Samza 0.10.0 Release Candidate 2

2015-12-09 Thread Jacob Maes
+1 [non binding]. Ran > ./gradlew build, > ./bin/check-all.sh, and > ./bin/integration-tests.sh /tmp/samza-tests from my Mac and all were successful. I saw some checkstyle errors when I used gradle 2.9, but it was fine with gradle 2.2 and 2.3. I created SAMZA-837 for gradle 2.9 compatibility.

Re: Review Request 40933: SAMZA-829: Add YARN configure doc to allow clean shutdown for large state jobs

2015-12-09 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40933/#review109673 --- Ship it! Ship It! - Boris Shkolnik On Dec. 3, 2015, 11:10

Re: [VOTE] Samza 0.10.0 Release Candidate 2

2015-12-09 Thread Boris Shkolnik
I've opened a ticket to track this rocksdb:test failure: 1. SAMZA-836 On Wed, Dec 9, 2015 at 7:11 PM, Boris Shkolnik wrote: > +1 (non-binding). > One note. I failed for me couple of times with the test below, but it >

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

2015-12-09 Thread Tao Feng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41106/ --- (Updated Dec. 10, 2015, 4:34 a.m.) Review request for samza. Repository:

Re: [VOTE] Samza 0.10.0 Release Candidate 2

2015-12-09 Thread Chris Riccomini
+1 binding On Wed, Dec 9, 2015 at 7:16 PM, Boris Shkolnik wrote: > I've opened a ticket to track this rocksdb:test failure: > >1. SAMZA-836 > > > On Wed, Dec 9, 2015 at 7:11 PM, Boris Shkolnik wrote: > >

Re: Review Request 40857: SAMZA 826 Fix string format issue with log message in ContainerUtil

2015-12-09 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40857/#review109674 --- Ship it! Ship It! - Boris Shkolnik On Dec. 2, 2015, 7:53 a.m.,

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

2015-12-09 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41106/#review109687 --- Ship it! Ship It! - Jake Maes On Dec. 10, 2015, 4:34 a.m., Tao

Review Request 41144: SAMZA-587: Create SystemConsumer and SystemProducer for ActiveMQ

2015-12-09 Thread Ben Damer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41144/ --- Review request for samza. Repository: samza Description --- Integration

Re: [VOTE] Samza 0.10.0 Release Candidate 2

2015-12-09 Thread Tao Feng
+1 from my side(non-binding). I download the package and successfully run all the unit tests without failure. On Tue, Dec 8, 2015 at 3:38 PM, Yi Pan wrote: > Hey all, > > > This is a call for a vote on a release of Apache Samza 0.10.0. Thanks to > everyone who has