Re: [DISCUSS] Moving to github/pull-request for code review and check-in

+1. Calcite uses pull requests for contributions from non-committers and according to my experience with Calcite, pull requests are easier than the current approach we follow in Samza. Milinda On Thu, Feb 18, 2016 at 9:09 PM, Roger Hoover wrote: > +1 - Thanks for

Re: [DISCUSS] Moving to github/pull-request for code review and check-in

+1 - Thanks for bringing this up, Yi. I've done it both ways and feel pull requests are much easier. Sent from my iPhone > On Feb 18, 2016, at 4:25 PM, Navina Ramesh > wrote: > > +1 > > Haven't tried any contribution with pull requests. But sounds simpler than

Re: [DISCUSS] Moving to github/pull-request for code review and check-in

Yay! > On Feb 18, 2016, at 7:25 PM, Navina Ramesh > wrote: > > +1 > > Haven't tried any contribution with pull requests. But sounds simpler than > attaching the patch to JIRA. > > Navina > >> On Thu, Feb 18, 2016 at 4:01 PM, Jacob Maes

Re: [DISCUSS] Moving to github/pull-request for code review and check-in

+1 As a relatively new contributor to Samza, I've certainly felt the current process was overly-complicated. On Thu, Feb 18, 2016 at 3:53 PM, Yi Pan wrote: > Hi, all, > > I want to start the discussion on our code review/commit process. > > I felt that our code review and

[DISCUSS] Moving to github/pull-request for code review and check-in

Hi, all, I want to start the discussion on our code review/commit process. I felt that our code review and check-in process is a little bit cumbersome: - developers need to create RBs and attach diff to JIRA - committers need to review RBs, dowload diff and apply, then push. It would be much

Re: Review Request 43053: allow warning instead of fail in case of invalid num of partitions in the checkpoint partition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43053/#review119748 --- Ship it! Just one nit.

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/ --- (Updated Feb. 18, 2016, 10:28 p.m.) Review request for samza, Navina Ramesh,

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/ --- (Updated Feb. 18, 2016, 10:29 p.m.) Review request for samza, Navina Ramesh,

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/ --- (Updated Feb. 18, 2016, 10:20 p.m.) Review request for samza, Navina Ramesh,

Re: Review Request 43053: allow warning instead of fail in case of invalid num of partitions in the checkpoint partition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43053/ --- (Updated Feb. 18, 2016, 8:04 p.m.) Review request for samza. Changes ---

Re: Review Request 43053: allow warning instead of fail in case of invalid num of partitions in the checkpoint partition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43053/ --- (Updated Feb. 18, 2016, 7:21 p.m.) Review request for samza. Changes ---

Re: Review Request 43589: Avoid unnecessary flushes in CachedStore

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43589/#review119654 --- Ship it! lgtm! Thanks! - Yi Pan (Data Infrastructure) On

Re: Review Request 43648: SAMZA-872: removed unsafe log4j DaillyRollingFileAppender from hello-samza

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43648/#review119633 --- Ship it! Ship It! - Jagadish Venkatraman On Feb. 17, 2016,

Re: key value store restore time

Samza 0.10 introduces the feature of Yarn host affinity for this exact reason. For jobs that need to bootstrap lots of state, downtime during bootstrapping is not acceptable. In our production usecases, we've observed bootstrap times from 25 mins to about 30 seconds. Please refer

key value store restore time

We are starting to use the key-value store with rocksdb. We are trying to offically add Samza to our stack and functionally everything is great. But, I am seeing minutes to hours restore time. Does anyone have any benchmarks on data size versus restore time? My big question is how will this