Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

2016-05-06 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46644/#review132109 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On May 6,

Re: Review Request 47073: SAMZA-946 - ConcurrentModificationException in TaskAssignmentManager

2016-05-06 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47073/#review132090 --- Ship it! +1 lgtm! - Navina Ramesh On May 6, 2016, 5:30

Review Request 47073: SAMZA-946 - ConcurrentModificationException in TaskAssignmentManager

2016-05-06 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47073/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

2016-05-06 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46856/#review132079 --- Ship it! Looks good ! +1 - Navina Ramesh On May 5, 2016,

Re: Review Request 47029: SAMZA-932 port collisions in JmxServer

2016-05-06 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47029/#review132076 --- Ship it! LGTM! Thanks! - Yi Pan (Data Infrastructure) On

Re: Review Request 47029: SAMZA-932 port collisions in JmxServer

2016-05-06 Thread Jake Maes
> On May 6, 2016, 4:27 p.m., Boris Shkolnik wrote: > > samza-core/src/main/scala/org/apache/samza/metrics/JmxServer.scala, line 92 > > > > > > Can you please add a log line, so we can know what port was chosen. see

Re: Review Request 47029: SAMZA-932 port collisions in JmxServer

2016-05-06 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47029/#review132060 ---

Re: Review Request 47029: SAMZA-932 port collisions in JmxServer

2016-05-06 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47029/#review132059 --- Ship it! For my sake, can you explain why the first solution