Re: Review Request 48459: SAMZA-964 Improve the performance of the continuous OFFSET checkpointing for logged stores

2016-06-08 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48459/ --- (Updated June 9, 2016, 4:48 a.m.) Review request for samza, Boris Shkolnik,

Review Request 48459: SAMZA-964 Improve the performance of the continuous OFFSET checkpointing for logged stores

2016-06-08 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48459/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina

Re: Review Request 37026: SAMZA-727: Support for Kerberos

2016-06-08 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/#review136742 ---

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

2016-06-08 Thread Xinyu Liu
> On June 6, 2016, 6:22 p.m., Chris Pettitt wrote: > > samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala, > > line 528 > > > > > > How about actually capturing the test failure and

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

2016-06-08 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48182/ --- (Updated June 9, 2016, 12:33 a.m.) Review request for samza, Chris Pettitt,

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

2016-06-08 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48182/#review136735 --- Ship it!

Re: Review Request 37026: SAMZA-727: Support for Kerberos

2016-06-08 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37026/#review136733 --- Fix it, then Ship it! LGTM. We are also trying to test it

Re: Review Request 48213: SAMZA-960: Make system producer thread safe

2016-06-08 Thread Xinyu Liu
> On June 8, 2016, 3:36 p.m., Chris Pettitt wrote: > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala, > > line 89 > > > > > > You need to save the value of the producer before

Re: Review Request 48213: SAMZA-960: Make system producer thread safe

2016-06-08 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48213/ --- (Updated June 8, 2016, 11:53 p.m.) Review request for samza, Chris Pettitt,

Re: Review Request 48356: RFC: Samza as a library

2016-06-08 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48356/ --- (Updated June 8, 2016, 9:59 p.m.) Review request for samza and Chris Pettitt.

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

2016-06-08 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48243/#review136357 --- Biggest take away on this pass is that the async run loop code

Re: Review Request 48393: Integrate Kerberos with JC UI refactoring (part 2).

2016-06-08 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48393/#review136675 ---

Re: Review Request 37026: SAMZA-727: Support for Kerberos

2016-06-08 Thread Chen Song
> On May 24, 2016, 3:31 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala, > > line 111 > > > > > > Instead of removing this completely, I