Review Request 48811: SAMZA-968 - SequenceFileHdfsFileWriter does not close file properly

2016-06-16 Thread Benjamin Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48811/ --- Review request for samza. Repository: samza Description --- Create

Review Request 48808: Rebase samza-41 with master

2016-06-16 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48808/ --- Review request for samza. Repository: samza Description --- Rebase

Re: Bug in SequenceFileHdfsFileWriter

2016-06-16 Thread Benjamin Smith
Sure, looks like a straightforward enough change. I've created: https://issues.apache.org/jira/browse/SAMZA-968 I don't see anyway to assign it to myself though? From: Yi Pan Sent: Thursday, June 16, 2016 1:02:59 PM To:

Re: Bug in SequenceFileHdfsFileWriter

2016-06-16 Thread Yi Pan
Hi, Benjamin, Thanks a lot for reporting this! It makes sense from reading the posts. Could you open a JIRA? Are you interested in assigning to yourself and contribute the fix? Thanks a lot again! -Yi On Thu, Jun 16, 2016 at 9:52 AM, Benjamin Smith < ben.sm...@ranksoftwareinc.com> wrote: > >

Re: Manually Commit Offsets?

2016-06-16 Thread Yi Pan
Hi, Jeremiah, You can wait in the StreamTask.process(), which essentially will block the whole container and no more Kafka messages will be delivered to the StreamTask. -Yi On Wed, Jun 15, 2016 at 12:13 PM, Jeremiah Adams wrote: > Thank you for the info. > > Is

Bug in SequenceFileHdfsFileWriter

2016-06-16 Thread Benjamin Smith
Hello, I am working on a project where we are integrating Samza and Hive. As part of this project, we ran into an issue where sequence files written from Samza were taking a long time (hours) to completely sync with HDFS. After some Googling and digging into the code, it appears that the

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

2016-06-16 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48243/#review138013 --- Fix it, then Ship it! Contingent on perf tests, of course.

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

2016-06-16 Thread Chris Pettitt
> On June 15, 2016, 3:08 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java, line 188 > > > > > > Do we need to handle the case that the SSP is not in the mappings or is