Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

> On Aug. 25, 2016, 12:30 a.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/api/overview.md, line 22 > > > > > > "You should implement StreamTask for synchronous process, e.g. a > > computation that d

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review147252 --- docs/learn/documentation/versioned/jobs/configuration-table.html

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/ --- (Updated Aug. 30, 2016, 12:49 a.m.) Review request for samza, Chris Pettitt, Na

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/ --- (Updated Aug. 30, 2016, 12:32 a.m.) Review request for samza, Boris Shkolnik, C

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/#review147248 --- samza-api/src/main/java/org/apache/samza/system/SystemStreamParti

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/#review147245 --- Fix it, then Ship it! Generally looks great! Thanks a for clean

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

> On Aug. 26, 2016, 5:06 p.m., Xinyu Liu wrote: > > samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java, line 540 > > > > > > I think it might be cleaner to have two flags, one indicating > > endOfStrea

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/ --- (Updated Aug. 29, 2016, 11:47 p.m.) Review request for samza, Boris Shkolnik, C

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

> On Aug. 26, 2016, 7:51 p.m., Chris Pettitt wrote: > > samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java, > > line 31 > > > > > > How likely are we to collide with this? Thats the problem

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

> On Aug. 29, 2016, 4:19 p.m., Jake Maes wrote: > > samza-api/src/main/java/org/apache/samza/system/SystemStreamPartitionIterator.java, > > line 79 > > > > > > Would it be better to move this method to IncomingMessag

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/#review147135 --- samza-api/src/main/java/org/apache/samza/system/SystemStreamParti

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

> On Aug. 26, 2016, 4:01 p.m., Chris Pettitt wrote: > > samza-operator/src/main/java/org/apache/samza/operators/api/MessageStream.java, > > line 52 > > > > > > Minor: final after access modifier for consistency with

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

> On Aug. 26, 2016, 5:27 p.m., Chris Pettitt wrote: > > samza-operator/src/main/java/org/apache/samza/operators/api/Scan.java, line > > 32 > > > > > > I wonder why the user doesn't just write the helper to extract