Re: Review Request 47994: SAMZA-915: implementation of StreamPipeline and operator runtime impl classes

2016-10-04 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47994/#review151443 ---

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-04 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review151439 --- Looks better, but I think there's still one major part missing.

Re: Review Request 47994: SAMZA-915: implementation of StreamPipeline and operator runtime impl classes

2016-10-04 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47994/#review151356 ---

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-10-04 Thread Hai Lu
> On Sept. 29, 2016, 10:02 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsConfig.scala, > > line 197 > > > > > > Thinking of this more, I would prefer

Re: Review Request 51142: SAMZA-967: HDFS System Consumer

2016-10-04 Thread Hai Lu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51142/ --- (Updated Oct. 5, 2016, 12:02 a.m.) Review request for samza, Yi Pan (Data

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-04 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/ --- (Updated Oct. 4, 2016, 11:33 p.m.) Review request for samza. Repository:

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-04 Thread Shanthoosh Venkataraman
> On Oct. 4, 2016, 1:57 a.m., Jake Maes wrote: > > samza-core/src/test/scala/org/apache/samza/storage/TestTaskStorageManager.scala, > > line 293 > > > > > > 2 nits: > > 1. Can you swap this test with the next

Re: [DISCUSS] [VOTE] Apache Samza 0.11.0 RC0

2016-10-04 Thread Navina Ramesh (Apache)
Verified MD5, signature. Ran bin/check-all.sh on MacOS. My RHEL box is broken. I think others have tested it on RHEL. Hence, +1 (binding) from me! **On a side note** I think we need to upgrade the gradle version used by the bootstrap script to 2.6 or higher. At least, make sure that Samza

Question about e2e exact once

2016-10-04 Thread Gavin Li
Hi, Asked in the IRC, no responses, so trying here. I'm thinking if we can implement end to end exact once semantics based on Kafka's concept of client side offset tracking. In the local RocksDB, store the kafka offset for every value. Then when updating the value always check if the current

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-10-04 Thread Yi Pan (Data Infrastructure)
> On Oct. 4, 2016, 4:34 p.m., Jagadish Venkatraman wrote: > > samza-operator/src/test/java/org/apache/samza/task/JoinOperatorTask.java, > > line 40 > > > > > > Why should this be public? Can't it be package

Re: [DISCUSS] [VOTE] Apache Samza 0.11.0 RC0

2016-10-04 Thread Jakob Homan
+1 binding. Verified MD5, checked code, built and tested. Good job, everyone. -Jakob On 4 October 2016 at 09:23, Jacob Maes wrote: > +1 (non-binding) > > Downloaded and bin/check-all.sh on OSX > Downloaded, built and ran unit tests on RHEL > > I got a checkstyle error

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-10-04 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47835/#review151345 --- Fix it, then Ship it!

Re: [DISCUSS] [VOTE] Apache Samza 0.11.0 RC0

2016-10-04 Thread Jacob Maes
+1 (non-binding) Downloaded and bin/check-all.sh on OSX Downloaded, built and ran unit tests on RHEL I got a checkstyle error when I tried to run bin/check-all.sh on RHEL, but I think it's something environmental. Looks good. On Mon, Oct 3, 2016 at 4:19 PM, Jagadish Venkatraman

Re: Review Request 51689: Fix SAMZA-1012 - Generated changelog mappings are not consistent

2016-10-04 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51689/#review151342 --- Ship it! Ship It! - Jake Maes On Sept. 13, 2016, 12:26

Re: Review for SAMZA-1012

2016-10-04 Thread Jacob Maes
I'm on it! On Tue, Oct 4, 2016 at 6:22 AM, Tommy Becker wrote: > Could I bother a committer for a review of this patch? > > > https://reviews.apache.org/r/51689/ > > -- > Tommy Becker > Senior Software Engineer > > Digitalsmiths > A TiVo Company > >

Review for SAMZA-1012

2016-10-04 Thread Tommy Becker
Could I bother a committer for a review of this patch? https://reviews.apache.org/r/51689/ -- Tommy Becker Senior Software Engineer Digitalsmiths A TiVo Company www.digitalsmiths.com tobec...@tivo.com