Re: Review Request 52492: Adding monitor to clean up stale local stores of jobs/tasks.

2016-10-24 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52492/#review153757 --- Fix it, then Ship it! ~15 documentation references to YARN shou

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-10-24 Thread Jake Maes
> On Oct. 17, 2016, 9:38 p.m., Jake Maes wrote: > > One last thing that occurs to me. Since DefaultResourceFactory now includes both JobsResource and TasksResource, can you make sure the tutorial still works as written? We need every step to be exact s.t. users aren't confused. http://samza.a

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-10-24 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52168/ --- (Updated Oct. 24, 2016, 10 p.m.) Review request for samza. Repository: samza

Re: Review Request 52168: Tasks endpoint to list the complete details of all tasks related to a job

2016-10-24 Thread Shanthoosh Venkataraman
> On Oct. 17, 2016, 9:38 p.m., Jake Maes wrote: > > docs/learn/documentation/versioned/rest/resources/tasks.md, line 105 > > > > > > This comment still looks out of place. Maybe it should just be > > incorporated in

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-24 Thread Prateek Maheshwari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review153741 --- Ship it! Looks good to me, thanks. samza-core/src/main/scala/