----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53826/#review156279 -----------------------------------------------------------
docs/learn/documentation/versioned/container/checkpointing.md (line 126) <https://reviews.apache.org/r/53826/#comment226477> Somewhat redundant with previous sentence, can merge. docs/learn/documentation/versioned/container/checkpointing.md (line 128) <https://reviews.apache.org/r/53826/#comment226478> "One such use case" "High Level Kafka Consumer", since that's how Kafka refers to it. docs/learn/documentation/versioned/container/checkpointing.md (line 129) <https://reviews.apache.org/r/53826/#comment226479> "rely on ACKs" "An example would be" "can only be done by the consumer" docs/learn/documentation/versioned/container/checkpointing.md (line 132) <https://reviews.apache.org/r/53826/#comment226480> "implement the" docs/learn/documentation/versioned/container/checkpointing.md (line 138) <https://reviews.apache.org/r/53826/#comment226481> Should we clarify what the 'offsets' parameter being passed to this callback and the checkpointing behavior is? Specifically, that Samza will still save all offsets it knows about in the checkpoint, notify listeners about all of them, and (on restart) attempt to `seek()` from the checkpointed offset for all systems? "Note: The" or "Note that the" - Prateek Maheshwari On Nov. 16, 2016, 3:28 p.m., Boris Shkolnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53826/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 3:28 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-1046 > https://issues.apache.org/jira/browse/SAMZA-1046 > > > Repository: samza > > > Description > ------- > > added user documentation for Checkpoint callbacks > > > Diffs > ----- > > docs/learn/documentation/versioned/container/checkpointing.md > 6f8c6d694be92f973af456ddd518d70540abe5c3 > > Diff: https://reviews.apache.org/r/53826/diff/ > > > Testing > ------- > > > Thanks, > > Boris Shkolnik > >
