Re: [DISCUSS] SAMZA-1141 - Apache Samza Development Process Improvements

2017-03-14 Thread Navina Ramesh
Xinyu, I considered doing that as an example. But I want to keep SEP to be only for technical discussions and not process related proposals. Navina On Mar 14, 2017 17:23, "xinyu liu" wrote: > +1 on this proposal too. Could you actually put this proposal as the first >

Re: [DISCUSS] SAMZA-1141 - Apache Samza Development Process Improvements

2017-03-14 Thread xinyu liu
+1 on this proposal too. Could you actually put this proposal as the first SEP (like SEP-0), so it serves an example of how it will look like in practice? Xinyu On Tue, Mar 14, 2017 at 3:34 PM, Navina Ramesh wrote: > Just to clarify: The proposal for code and

Re: Understanding metrics

2017-03-14 Thread xinyu liu
Hi, Ankit, When running your job in multithreading, block-ns here actually includes the process_ns. This is because after your task.process() is submitted to the thread pool, the run loop thread will be blocked until the process() is complete for one of the task. It's interesting that block-ns

Re: [DISCUSS] SAMZA-1141 - Apache Samza Development Process Improvements

2017-03-14 Thread Navina Ramesh
Just to clarify: The proposal for code and design process change is attached as a PDF/markdown to the JIRA - SAMZA-1141. Also, please show your support specifically for code and design process. My bad for not calling it out earlier :) Thanks! Navina On Tue, Mar 14, 2017 at 3:30 PM, Jagadish

Re: Understanding metrics

2017-03-14 Thread Ankit Malhotra
Wait, block-ns = 0.3ms (300,000ns). Also, why are we not adding in choose-ns? Thanks Ankit On 3/14/17, 6:26 PM, "Jagadish Venkatraman" wrote: I would expect (process_ns + block_ns) to be almost the same as 0.15 which makes sense. process_ns = 0.12 ms

Re: [DISCUSS] SAMZA-1141 - Apache Samza Development Process Improvements

2017-03-14 Thread Jagadish Venkatraman
Thanks for writing this up. I'm +1 on this proposal. On Tue, Mar 14, 2017 at 3:15 PM, Navina Ramesh (Apache) wrote: > Hi everyone, > > We switched to using Pull Requests for code reviews a few months back. > Clearly, there are some drawbacks to that model and we are trying

Understanding metrics

2017-03-14 Thread Ankit Malhotra
Hi, We are trying to understand metrics that are being populated by our samza job and are a little confused what each of these metrics mean especially since we’re running the job with a thread pool. · We have 3 input streams · job.container.thread.pool.size=3 · 1

[GitHub] samza pull request #60: SAMZA-1091: Implement key-based inner join operator ...

2017-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] samza pull request #85: SAMZA-1140 : Non blocking commit in Async Runloop

2017-03-14 Thread shanthoosh
GitHub user shanthoosh opened a pull request: https://github.com/apache/samza/pull/85 SAMZA-1140 : Non blocking commit in Async Runloop You can merge this pull request into a Git repository by running: $ git pull https://github.com/shanthoosh/samza asyncCommitSupport