[GitHub] samza pull request #134: SAMZA-1229: Disk space monitor should only count da...

2017-04-20 Thread prateekm
GitHub user prateekm opened a pull request: https://github.com/apache/samza/pull/134 SAMZA-1229: Disk space monitor should only count data in use by the container You can merge this pull request into a Git repository by running: $ git pull https://github.com/prateekm/samza

Re: [DISCUSS] SEP-2: ApplicationRunner Design

2017-04-20 Thread Chris Pettitt
It might be worth taking a look at how Beam does test streams. The API is more powerful than just passing in a queue, e.g.: TestStream source = TestStream.create(StringUtf8Coder.of()) .addElements(TimestampedValue.of("this", start)) .addElements(TimestampedValue.of("that", start))

Re: [DISCUSS] SEP-2: ApplicationRunner Design

2017-04-20 Thread Jacob Maes
Thanks for the SEP! +1 on introducing these new components -1 on the current definition of their roles (see Design feedback below) *Design* - If LocalJobRunner and RemoteJobRunner handle the different methods of launching a Job, what additional value do the different types of

Re: Review Request 43244: support elasticsearch version 2.x

2017-04-20 Thread Yi Pan (Data Infrastructure) via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43244/#review172454 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On Feb. 5,