[GitHub] [samza] prateekm commented on issue #980: Cleaned up AM logs and naming convention

prateekm commented on issue #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#issuecomment-478143981 @rmatharu Are you ok with leaving the javadoc/code references to a 'resource' in the ACA etc. as-is and only updating the logs? The term 'resource

[GitHub] [samza] prateekm commented on a change in pull request #980: Cleaned up AM logs and naming convention

prateekm commented on a change in pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#discussion_r270566382 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java ## @@ -

[GitHub] [samza] rmatharu commented on issue #980: Cleaned up AM logs and naming convention

rmatharu commented on issue #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#issuecomment-478105132 Looks good, just some minor nits. I can do the StandbyContainerManager cleanup after this. ---

[GitHub] [samza] rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention

rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#discussion_r270527688 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -178

[GitHub] [samza] rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention

rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#discussion_r270527952 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -281

[GitHub] [samza] rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention

rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#discussion_r270527952 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -281

[GitHub] [samza] rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention

rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#discussion_r270527688 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java ## @@ -178

[GitHub] [samza] rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention

rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#discussion_r270526467 ## File path: samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnClusterResourceManager.java ## @@ -750,14

[GitHub] [samza] rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention

rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#discussion_r270526467 ## File path: samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnClusterResourceManager.java ## @@ -750,14

[GitHub] [samza] rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention

rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#discussion_r270516352 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java ## @@ -

[GitHub] [samza] rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention

rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#discussion_r270516141 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java ## @@ -

[GitHub] [samza] rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention

rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#discussion_r270500918 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java ## @@ -

[GitHub] [samza] rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention

rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#discussion_r270498446 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java ## @@ -

[GitHub] [samza] rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention

rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#discussion_r270498332 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java ## @@ -

[GitHub] [samza] rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention

rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#discussion_r270496794 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java ## @@ -

[GitHub] [samza] prateekm commented on issue #980: Cleaned up AM logs and naming convention

prateekm commented on issue #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980#issuecomment-478070467 @vjagadish1989 @rmatharu Please take a look. This is an automated message from the

[GitHub] [samza] prateekm opened a new pull request #980: Cleaned up AM logs and naming convention

prateekm opened a new pull request #980: Cleaned up AM logs and naming convention URL: https://github.com/apache/samza/pull/980 1. To disambiguate between YARN containers and Samza Processor. 2. Use consistent logging format. Now can search logs with strings "Container ID: ", "Processo