Re: [NEED COMMENTS] import-control & checkstyle plugin

2016-07-11 Thread Jacob Maes
I don't particularly mind that it doesn't get cleaned up. Theoretically if it was once reasonable for one class/package to be referenced within another, it will continue to be reasonable, even if the code no longer makes the reference. That said, import control has been a pain every time we add

Re: [NEED COMMENTS] import-control & checkstyle plugin

2016-07-11 Thread Yi Pan
+1 on removing the import control. The original idea to include the checkstyle.xml is to enforce some coding style guidelines, not to strictly control the imports. W/ the outdated import control list, it practically does not serve the purpose... On Mon, Jul 11, 2016 at 4:02 PM, Navina Ramesh

[NEED COMMENTS] import-control & checkstyle plugin

2016-07-11 Thread Navina Ramesh
Hi Samza devs, Lately, with the major re-works such as standalone, multithreading etc, it is getting harder to keep track of the package/class dependencies in import-control.xml. What I have noticed is that we don't bother removing the class/package dependencies when it is no longer valid. This