Re: [VOTE] SEP-12: Integration Test Framework

Hi Yi, - Event Builder Stream (p2): This will be part of different SEP, so we can discuss alternatives then, but yea this system will leverage InMemorySystem - Closable Task: sure will update it - CollectionStreamSystem will be now changed to CollectionStreamSystemSpec as per the discussion

Re: [VOTE] SEP-12: Integration Test Framework

Hi, Sanil, Thanks for the proposal! Overall, looks good to me. Here a few minor comments: - Event Builder Stream (p2): why do we need this instead of injecting events along w/ messages/timer function in CollectionStream? - Closable Task: if there is a per-task system resource opened, close()

Re: [VOTE] SEP-12: Integration Test Framework

+1 On Thu, May 17, 2018 at 11:54 AM, santhosh venkat < santhoshvenkat1...@gmail.com> wrote: > +1. > > Thanks. > > On Thu, May 17, 2018 at 10:13 AM, Jacob Maes wrote: > > > +1 > > > > On Thu, May 17, 2018 at 9:56 AM, Jagadish Venkatraman < > > jagadish1...@gmail.com> wrote:

Re: [VOTE] SEP-12: Integration Test Framework

+1 can't wait to have this in! :) From: Jacob Maes <jacob.m...@gmail.com> Sent: Thursday, May 17, 2018 10:13:57 AM To: dev@samza.apache.org Subject: Re: [VOTE] SEP-12: Integration Test Framework +1 On Thu, May 17, 2018 at 9:56 AM, Jagadish Venka

Re: [VOTE] SEP-12: Integration Test Framework

+1 On Thu, May 17, 2018 at 9:56 AM, Jagadish Venkatraman < jagadish1...@gmail.com> wrote: > Thanks Sanil for the proposal. This will go a long way in simplifying > testing of Samza applications. > > +1 (binding) > > > > On Thu, May 17, 2018 at 9:45 AM, Daniel Nishimura >

Re: [VOTE] SEP-12: Integration Test Framework

Thanks Sanil for the proposal. This will go a long way in simplifying testing of Samza applications. +1 (binding) On Thu, May 17, 2018 at 9:45 AM, Daniel Nishimura wrote: > +1 > > Looks great! > > On Thu, May 17, 2018 at 9:08 AM, Xinyu Liu wrote:

Re: [VOTE] SEP-12: Integration Test Framework

+1 Looks great! On Thu, May 17, 2018 at 9:08 AM, Xinyu Liu wrote: > +1 > > The proposal looks great to me. Look forward to seeing the implementation. > > Thanks, > Xinyu > > On Wed, May 16, 2018 at 6:12 PM, Sanil Jain > wrote: > > > Hi All, > > >

Re: [VOTE] SEP-12: Integration Test Framework

no opinion [ ] -1 disapprove (and reason why) Thanks Sanil From: Sanil Jain <snj...@linkedin.com> Sent: Thursday, May 10, 2018 1:59:59 PM To: dev@samza.apache.org Subject: [VOTE] SEP-12: Integration Test Framework Hi All, This is a call for a vote for S

[VOTE] SEP-12: Integration Test Framework

Hi All, This is a call for a vote for Samza's Integration Test Framework as described by: https://cwiki.apache.org/confluence/display/SAMZA/SEP-12%3A+Integration+Test+Framework The vote will be open for 5 days (ending at 2:00PM Thursday, 05/17/2018). Please download the release candidate,