Re: [VOTE] SEP-8: Add in-memory system consumer & producer

2017-10-04 Thread Yi Pan
+1. The updated design looks good to me! Looking forward to its implementation. Minor: if this SEP has direct dependency on SEP-2 and other ApplicationRunner related API changes, please make it clear (i.e. what we can implement w/o being blocked and what need to wait till the API changes are

Re: [VOTE] SEP-8: Add in-memory system consumer & producer

2017-09-26 Thread Jagadish Venkatraman
LGTM , +1 on the overall design. This will drastically improve testing of Samza applications! -- Jagdish On Thu, Sep 14, 2017 at 1:23 AM, Yi Pan wrote: > Hi, Bharath, > > Overall looks good! I have the following comments: > > i) Question on the Type of IME + data

Re: [VOTE] SEP-8: Add in-memory system consumer & producer

2017-09-15 Thread Bharath Kumarasubramanian
Thanks for your feedback. Answers inline On 9/14/17, 1:23 AM, "Yi Pan" wrote: Hi, Bharath, Overall looks good! I have the following comments: i) Question on the Type of IME + data partition: How do we enforce that user adds IME w/ the

Re: [VOTE] SEP-8: Add in-memory system consumer & producer

2017-09-14 Thread Yi Pan
Hi, Bharath, Overall looks good! I have the following comments: i) Question on the Type of IME + data partition: How do we enforce that user adds IME w/ the expected partition id to the corresponding sub-collection? ii) In the architecture graph, what's the difference between SSP queues and

Re: [VOTE] SEP-8: Add in-memory system consumer & producer

2017-09-06 Thread Navina Ramesh
t;Usage Example" Overall, +1 on this. We need this asap!!  Thanks! Navina From: xinyu liu <xinyuliu...@gmail.com> Sent: Wednesday, September 6, 2017 2:06:45 PM To: dev@samza.apache.org Subject: Re: [VOTE] SEP-8: Add in-memory system consumer

Re: [VOTE] SEP-8: Add in-memory system consumer & producer

2017-09-06 Thread xinyu liu
+1 on the overall design. This will make testing a lot easier! Thanks, Xinyu On Wed, Sep 6, 2017 at 10:45 AM, Bharath Kumara Subramanian < codin.mart...@gmail.com> wrote: > Hi all, > > Can you please vote for SEP-8? > You can find the design document here >

[VOTE] SEP-8: Add in-memory system consumer & producer

2017-09-06 Thread Bharath Kumara Subramanian
Hi all, Can you please vote for SEP-8? You can find the design document here . Thanks, Bharath