Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

2015-07-22 Thread Yan Fang
to Elasticsearch System Producer Diffs - samza-core/src/main/java/org/apache/samza/metrics/MetricGroup.java PRE-CREATION samza-core/src/main/java/org/apache/samza/metrics/MetricsBase.java PRE-CREATION samza-core/src/main/scala/org/apache/samza/metrics/MetricsHelper.scala

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

2015-07-22 Thread Roger Hoover
Description --- SAMZA-733 Add metrics to Elasticsearch System Producer Diffs (updated) - samza-core/src/main/java/org/apache/samza/metrics/MetricGroup.java PRE-CREATION samza-core/src/main/java/org/apache/samza/metrics/MetricsBase.java PRE-CREATION samza-core/src/main/scala

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

2015-07-21 Thread Yan Fang
--- SAMZA-733 Add metrics to Elasticsearch System Producer Diffs - samza-core/src/main/java/org/apache/samza/metrics/MetricGroup.java PRE-CREATION samza-core/src/main/java/org/apache/samza/metrics/MetricsBase.java PRE-CREATION samza-core/src/main/scala/org/apache/samza/metrics

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

2015-07-21 Thread Roger Hoover
: samza Description --- SAMZA-733 Add metrics to Elasticsearch System Producer Diffs (updated) - samza-core/src/main/java/org/apache/samza/metrics/MetricGroup.java PRE-CREATION samza-core/src/main/java/org/apache/samza/metrics/MetricsBase.java PRE-CREATION samza-core/src/main

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

2015-07-21 Thread Roger Hoover
.) Review request for samza. Repository: samza Description --- SAMZA-733 Add metrics to Elasticsearch System Producer Diffs - samza-core/src/main/java/org/apache/samza/metrics/MetricGroup.java PRE-CREATION samza-core/src/main/java/org/apache/samza/metrics

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

2015-07-20 Thread Roger Hoover
--- Fixed tests and added base class for Java metrics Repository: samza Description --- SAMZA-733 Add metrics to Elasticsearch System Producer Diffs (updated) - samza-core/src/main/java/org/apache/samza/metrics/MetricGroup.java PRE-CREATION samza-core/src/main/java/org/apache

Metrics for Elasticsearch System Producer

2015-07-14 Thread Roger Hoover
Hi all, I've started using the new Elasticsearch System Producer (many thanks, Dan!) and decided to add some metrics to it. The JIRA ticket and review request links are here: https://issues.apache.org/jira/browse/SAMZA-733 https://reviews.apache.org/r/36473/ Cheers, Roger

Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

2015-07-14 Thread Roger Hoover
Add metrics to Elasticsearch System Producer Diffs - samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemFactory.java a277b69 samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java 7eb14a2

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

2015-07-14 Thread Yan Fang
/ --- (Updated July 14, 2015, 6:12 a.m.) Review request for samza. Repository: samza Description --- SAMZA-733 Add metrics to Elasticsearch System Producer Diffs - samza-elasticsearch/src/main/java/org

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

2015-07-14 Thread Roger Hoover
/36473/ --- (Updated July 14, 2015, 6:12 a.m.) Review request for samza. Repository: samza Description --- SAMZA-733 Add metrics to Elasticsearch System Producer Diffs - samza-elasticsearch/src/main/java

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

2015-07-14 Thread Roger Hoover
Description --- SAMZA-733 Add metrics to Elasticsearch System Producer Diffs - samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemFactory.java a277b69 samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

2015-07-14 Thread Yan Fang
--- SAMZA-733 Add metrics to Elasticsearch System Producer Diffs - samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemFactory.java a277b69 samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

2015-07-14 Thread Roger Hoover
, 2015, 6:12 a.m.) Review request for samza. Repository: samza Description --- SAMZA-733 Add metrics to Elasticsearch System Producer Diffs - samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemFactory.java a277b69

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

2015-07-14 Thread Yan Fang
metrics to Elasticsearch System Producer Diffs - samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemFactory.java a277b69 samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java 7eb14a2

Re: Review Request 36473: SAMZA-733 Add metrics to Elasticsearch System Producer

2015-07-14 Thread Roger Hoover
--- Removed extra space Repository: samza Description --- SAMZA-733 Add metrics to Elasticsearch System Producer Diffs (updated) - samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemFactory.java a277b69 samza-elasticsearch/src/main/java