Re: [DISCUSS] Hygene for merging PRs

2019-05-19 Thread Yi Pan
Hi, Cameron, That's generally the case. Thanks for Xinyu to bring this to our attention! +1 to the stated guidelines. -Yi On Fri, May 17, 2019 at 11:10 AM Cameron Lee wrote: > Thanks Xinyu for starting this thread. > I support the guidelines that you mentioned, with a couple clarifications >

Re: [DISCUSS] Hygene for merging PRs

2019-05-17 Thread Cameron Lee
Thanks Xinyu for starting this thread. I support the guidelines that you mentioned, with a couple clarifications regarding "PR Review": If a Samza PR is authored by a committer, then another second committer should provide an approval before that code is merged, correct? Once the second committer