Re: Review Request 34746: Adding new CoordinatorStreamMessage SetContainerHostMapping and LocalityManager (SAMZA-618)

2015-06-01 Thread Yi Pan (Data Infrastructure)
On May 30, 2015, 8:58 a.m., Yi Pan (Data Infrastructure) wrote: samza-core/src/main/java/org/apache/samza/container/LocalityManager.java, line 62 https://reviews.apache.org/r/34746/diff/2/?file=974783#file974783line62 This would be invoked twice by checkpointManager and

Re: Review Request 34746: Adding new CoordinatorStreamMessage SetContainerHostMapping and LocalityManager (SAMZA-618)

2015-06-01 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34746/#review86125 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On May 30,

Re: Review Request 34746: Adding new CoordinatorStreamMessage SetContainerHostMapping and LocalityManager (SAMZA-618)

2015-05-30 Thread Navina Ramesh
On May 30, 2015, 8:58 a.m., Yi Pan (Data Infrastructure) wrote: samza-core/src/main/java/org/apache/samza/container/LocalityManager.java, line 27 https://reviews.apache.org/r/34746/diff/2/?file=974783#file974783line27 nit: why is here a * import? not intentional :) On May 30,

Re: Review Request 34746: Adding new CoordinatorStreamMessage SetContainerHostMapping and LocalityManager (SAMZA-618)

2015-05-30 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34746/ --- (Updated May 30, 2015, 11:49 p.m.) Review request for samza, Chris Riccomini,

Re: Review Request 34746: Adding new CoordinatorStreamMessage SetContainerHostMapping and LocalityManager (SAMZA-618)

2015-05-29 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34746/ --- (Updated May 29, 2015, 6:32 p.m.) Review request for samza, Chris Riccomini,