Re: Review Request 37604: SAMZA-760 Samza Container should catch Throwables instead of just catching Exceptions

2015-10-08 Thread Aleksandar Bircakovic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37604/ --- (Updated Oct. 8, 2015, 9:42 a.m.) Review request for samza. Changes ---

Re: Review Request 37604: SAMZA-760 Samza Container should catch Throwables instead of just catching Exceptions

2015-10-06 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37604/#review101686 --- samza-core/src/main/scala/org/apache/samza/container/SamzaContaine

Re: Review Request 37604: SAMZA-760 Samza Container should catch Throwables instead of just catching Exceptions

2015-10-06 Thread Aleksandar Bircakovic
> On Oct. 1, 2015, 7:44 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala, > > line 599 > > > > > > Forgive me on ignorance on this ControlThrowa

Re: Review Request 37604: SAMZA-760 Samza Container should catch Throwables instead of just catching Exceptions

2015-10-01 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37604/#review101272 --- samza-core/src/main/scala/org/apache/samza/container/SamzaContaine

Re: Review Request 37604: SAMZA-760 Samza Container should catch Throwables instead of just catching Exceptions

2015-08-25 Thread Aleksandar Bircakovic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37604/ --- (Updated Aug. 25, 2015, 11:48 a.m.) Review request for samza. Changes ---

Re: Review Request 37604: SAMZA-760 Samza Container should catch Throwables instead of just catching Exceptions

2015-08-24 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37604/#review96145 --- Overall, LGTM. Could you also add a unit test to verify this? Thank

Review Request 37604: SAMZA-760 Samza Container should catch Throwables instead of just catching Exceptions

2015-08-19 Thread Aleksandar Bircakovic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37604/ --- Review request for samza. Repository: samza Description --- Added a catc