Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

> On Oct. 30, 2015, 6:06 p.m., Xinyu Liu wrote: > > samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala, > > line 132 > > > > > > I think scala prefers to use the companion object as the

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

> On Oct. 30, 2015, 6:06 p.m., Xinyu Liu wrote: > > samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala, > > line 132 > > > > > > I think scala prefers to use the companion object as the

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39806/ --- (Updated Nov. 2, 2015, 9:56 p.m.) Review request for samza, Chris Riccomini,

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39806/#review104814 --- Ship it! Ship It! - Jake Maes On Nov. 2, 2015, 9:56 p.m.,

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39806/#review104818 ---

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39806/ --- (Updated Nov. 2, 2015, 2:24 a.m.) Review request for samza, Chris Riccomini,

Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39806/ --- Review request for samza, Chris Riccomini, Jake Maes, Jagadish Venkatraman, and

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39806/ --- (Updated Oct. 30, 2015, 10:49 p.m.) Review request for samza, Chris Riccomini,

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39806/ --- (Updated Oct. 30, 2015, 8:53 p.m.) Review request for samza, Chris Riccomini,

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39806/ --- (Updated Oct. 31, 2015, 1:24 a.m.) Review request for samza, Chris Riccomini,

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

> On Oct. 30, 2015, 6:06 p.m., Xinyu Liu wrote: > > samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointManager.java, > > line 29 > > > > > > Just a nitpick: for java interfaces, all methods are public, so

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39806/#review104583 --- Ship it! Some minor suggestions. Overall the change looks good.