Re: How to implement broadcasted KeyValueStorage with 0.9

Can we make a kafka topic as KV store globally to all tasks, not partitioned? For example, we have a kafka topic "cache" and it has a 4 partitions. If we launch a container with 4 tasks, each task will have one partition of "cache" kafka topic and create a KV store instance. I want to make all 4 pa

Re: Review Request 46732: SAMZA-930 fix issue with json deserialisation in YarnUtil

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46732/#review131526 --- Can you please clarify in the descriptions - what was the issue an

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46856/#review131525 --- Fix it, then Ship it! Looks good. Mostly minor stuff that you c

Re: How to implement broadcasted KeyValueStorage with 0.9

This sounds like SAMZA-402 (https://issues.apache.org/jira/browse/SAMZA-402) which, unfortunately, hasn't been implemented yet. On Tue, May 3, 2016 at 7:48 AM, Bae, Jae Hyeon wrote: > Can we make a kafka topic as KV store globally to all tasks, not > partitioned? For example, we have a kafka t

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

> On May 3, 2016, 5:23 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/coordinator/StreamPartitionCountMonitor.java, > > line 107 > > > > > > This is not thread-safe, but I believe it could

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

> On May 3, 2016, 5:23 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/coordinator/StreamPartitionCountMonitor.java, > > line 107 > > > > > > This is not thread-safe, but I believe it could

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

> On May 3, 2016, 5:23 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/coordinator/StreamPartitionCountMonitor.java, > > line 107 > > > > > > This is not thread-safe, but I believe it could

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46856/ --- (Updated May 4, 2016, 12:18 a.m.) Review request for samza, Boris Shkolnik, Nav

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

> On May 3, 2016, 5:23 p.m., Chris Pettitt wrote: > > Looks good. Mostly minor stuff that you can choose to take or ignore. Appreciate the thoughtful comments. Implemented all of them. - Jake --- This is an automatically generated e-mai

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46856/ --- (Updated May 4, 2016, 12:30 a.m.) Review request for samza, Boris Shkolnik, Nav

Review Request 46952: SAMZA-944 Broadcast stream is not added properly in the prioritized tiers in the DefaultChooser

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46952/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, Navina Ramesh, Jagadish

Re: Review Request 46952: SAMZA-944 Broadcast stream is not added properly in the prioritized tiers in the DefaultChooser

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46952/ --- (Updated May 4, 2016, 12:42 a.m.) Review request for samza, Boris Shkolnik, Chr

Re: Review Request 46952: SAMZA-944 Broadcast stream is not added properly in the prioritized tiers in the DefaultChooser

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46952/#review131607 --- samza-core/src/main/java/org/apache/samza/config/DefaultChooserCo

Re: Review Request 46952: SAMZA-944 Broadcast stream is not added properly in the prioritized tiers in the DefaultChooser

> On May 4, 2016, 2 a.m., Jagadish Venkatraman wrote: > > samza-core/src/main/java/org/apache/samza/config/DefaultChooserConfig.java, > > line 36 > > > > > > any reason why this is not private? no *good* reason :-)

Re: Review Request 46952: SAMZA-944 Broadcast stream is not added properly in the prioritized tiers in the DefaultChooser

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46952/ --- (Updated May 4, 2016, 3:34 a.m.) Review request for samza, Boris Shkolnik, Chri

Re: Review Request 46952: SAMZA-944 Broadcast stream is not added properly in the prioritized tiers in the DefaultChooser

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46952/#review131633 --- Ship it! Thanks for addressing the nits. LGTM. Ship It! - Jag