[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386607 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -668,22 +631,86

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268384606 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -628,10 +589,12

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386258 ## File path: samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIntegrationTestHarness.java

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386045 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386127 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386095 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386706 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -668,22 +631,86

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268385471 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -711,4 +738,29 @@

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268385422 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java ## @@ -628,10 +589,12

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386149 ## File path: samza-test/src/test/java/org/apache/samza/test/harness/IntegrationTestHarness.java ## @@ -0,0 +1,192

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386358 ## File path: gradle/dependency-versions.gradle ## @@ -34,7 +34,7 @@ jodaTimeVersion = "2.2" joptSimpleVersion

[GitHub] [samza] shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268386258 ## File path: samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIntegrationTestHarness.java

[GitHub] [samza] shenodaguirguis commented on a change in pull request #966: Moving the Fixes from internal AvroRelConverter

shenodaguirguis commented on a change in pull request #966: Moving the Fixes from internal AvroRelConverter URL: https://github.com/apache/samza/pull/966#discussion_r268405483 ## File path: samza-sql/src/main/java/org/apache/samza/sql/avro/AvroRelConverter.java ## @@

[GitHub] [samza] shenodaguirguis commented on a change in pull request #966: Moving the Fixes from internal AvroRelConverter

shenodaguirguis commented on a change in pull request #966: Moving the Fixes from internal AvroRelConverter URL: https://github.com/apache/samza/pull/966#discussion_r268405596 ## File path: samza-sql/src/main/java/org/apache/samza/sql/avro/AvroRelConverter.java ## @@

[GitHub] [samza] shenodaguirguis commented on a change in pull request #966: Moving the Fixes from internal AvroRelConverter

shenodaguirguis commented on a change in pull request #966: Moving the Fixes from internal AvroRelConverter URL: https://github.com/apache/samza/pull/966#discussion_r268405722 ## File path: samza-sql/src/main/java/org/apache/samza/sql/avro/AvroRelConverter.java ## @@

[GitHub] [samza] dnishimura opened a new pull request #970: SAMZA-2143: Fix NPE in `CoordinatorStreamMessage#equals` and some clean-up to CoordinatorStreamSystemConsumer

dnishimura opened a new pull request #970: SAMZA-2143: Fix NPE in `CoordinatorStreamMessage#equals` and some clean-up to CoordinatorStreamSystemConsumer URL: https://github.com/apache/samza/pull/970 1) NPE exposed in CoordinatorStreamMessage#equals now that the metadata store allows