Re: Review Request 50082: SAMZA-973: Disk Quotas: clamp max delay, better measure processing time

2016-07-15 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50082/#review142459 --- Fix it, then Ship it!

Re: Review Request 50082: SAMZA-973: Disk Quotas: clamp max delay, better measure processing time

2016-07-15 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50082/#review142457 --- Ship it! +1. lgtm. - Yi Pan (Data Infrastructure) On July

Re: Review Request 49877: SAMZA-972: Holistic memory monitoring for SamzaContainer

2016-07-15 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49877/#review142434 ---

Re: Review Request 50082: SAMZA-973: Disk Quotas: clamp max delay, better measure processing time

2016-07-15 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50082/ --- (Updated July 15, 2016, 7:59 p.m.) Review request for samza. Repository:

Review Request 50082: SAMZA-973: Disk Quotas: clamp max delay, better measure processing time

2016-07-15 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50082/ --- Review request for samza. Repository: samza Description --- The delay

Re: Review Request 48213: SAMZA-960: Make system producer thread safe

2016-07-15 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48213/#review142418 --- Ship it! - Chris Pettitt On July 14, 2016, 12:43 a.m., Xinyu

Re: Review Request 49877: SAMZA-972: Holistic memory monitoring for SamzaContainer

2016-07-15 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49877/#review142417 --- Ship it! I would add at least a test to verify you can get a