Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

2016-06-08 Thread Xinyu Liu
To reply, visit: https://reviews.apache.org/r/48182/#review136335 ------- On June 9, 2016, 12:33 a.m., Xinyu Liu wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

2016-06-08 Thread Xinyu Liu
tests and local deployment. Thanks, Xinyu Liu

Re: Review Request 48213: SAMZA-960: Make system producer thread safe

2016-06-08 Thread Xinyu Liu
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48213/#review136654 --- On June 8, 2016, 11:53 p.m., Xinyu Liu wrote: > > ---

Re: Review Request 48213: SAMZA-960: Make system producer thread safe

2016-06-08 Thread Xinyu Liu
/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala 8e32bba6ced090f0fc8d4e5176fe0788df36981d Diff: https://reviews.apache.org/r/48213/diff/ Testing --- Unit tests and local testing. Thanks, Xinyu Liu

Review Request 48243: SAMZA-961: Async tasks and multithreading model

2016-06-03 Thread Xinyu Liu
/scala/org/apache/samza/system/TestSystemConsumers.scala 09da62e0f9a10f7c3683345a309c6278ff01fb4b Diff: https://reviews.apache.org/r/48243/diff/ Testing --- unit tests and local testing. Thanks, Xinyu Liu

Re: Review Request 48213: SAMZA-960: Make system producer thread safe

2016-06-03 Thread Xinyu Liu
04c9113fd6c3dd56c49ff46c8c1c0ff12f68e5e2 samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala 8e32bba6ced090f0fc8d4e5176fe0788df36981d Diff: https://reviews.apache.org/r/48213/diff/ Testing --- Unit tests and local testing. Thanks, Xinyu Liu

Review Request 48213: SAMZA-960: Make system producer thread safe

2016-06-03 Thread Xinyu Liu
/TestKafkaSystemProducer.scala 8e32bba6ced090f0fc8d4e5176fe0788df36981d Diff: https://reviews.apache.org/r/48213/diff/ Testing --- Unit tests and local testing. Thanks, Xinyu Liu

Re: [DISCUSS] Re-thinking the Samza Job Coordinator

2016-03-02 Thread xinyu liu
This is awesome! Samza will be able to run standalone or on different kinds of clusters, which can serve a wide range of applications. Glad to see this is happening. Thanks, Xinyu On Tue, Mar 1, 2016 at 8:48 AM, Jagadish Venkatraman wrote: > Hi all, > > Currently, the

Re: Understand Samza default metrics

2016-02-24 Thread Xinyu Liu
essage. But this average also includes time taken to process null > messages. So I don't trust the accuracy of that metric. > > Each metric emitted by Samza contains a header which includes job name, > job > id, container name and metric timestamp. You can use it to calculate > messag

Re: Understand Samza default metrics

2016-02-23 Thread xinyu liu
Hi, David, I didn't find a wiki page that contains the descriptions of all Samza metrics. You can find the basic metrics by googling the following classes: SamzaContainerMetrics, TaskInstanceMetrics, SystemConsumersMetrics and SystemProducersMetrics. For your example, you can use the

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

2016-02-23 Thread Xinyu Liu
ception.java (line 27) <https://reviews.apache.org/r/43350/#comment181838> is serialVersionUID needed here? If so please use the autogenerated one. - Xinyu Liu On Feb. 23, 2016, 9:43 p.m., Jake Maes wrote: > > --- &g

Re: Review Request 43053: allow warning instead of fail in case of invalid num of partitions in the checkpoint partition

2016-02-01 Thread Xinyu Liu
-kafka/src/main/scala/org/apache/samza/util/KafkaUtil.scala (line 162) <https://reviews.apache.org/r/43053/#comment178367> nitpick: the var name of "msg1" seems not very well chosen. Shall we do warn(msg + "...") instead? - Xinyu Liu On Feb. 1, 2016, 6:25

Review Request 41912: SAMZA-850: Yarn Job Validation Tool

2016-01-04 Thread Xinyu Liu
/41912/diff/ Testing --- Unit tests added to cover all the new methods/classes. Thanks, Xinyu Liu

Re: [VOTE] Samza 0.10.0 Release Candidate 2

2015-12-09 Thread xinyu liu
+1 on my side. I also ran the gradle build and unit tests without failure. Thanks, Xinyu On Wed, Dec 9, 2015 at 9:54 AM, Tao Feng wrote: > +1 from my side(non-binding). I download the package and successfully run > all the unit tests without failure. > > On Tue, Dec 8,

Review Request 41071: SAMZA-843: fix heap usage increase caused by container timer change

2015-12-07 Thread Xinyu Liu
ing --- Thanks, Xinyu Liu

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

2015-11-02 Thread Xinyu Liu
> On Oct. 30, 2015, 6:06 p.m., Xinyu Liu wrote: > > samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala, > > line 132 > > <https://reviews.apache.org/r/39806/diff/1/?file=1112956#file1112956line132> > > > > I think sc

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

2015-10-30 Thread Xinyu Liu
123) <https://reviews.apache.org/r/39806/#comment162817> I think scala prefers to use the companion object as the factory to create new instance (code before change). Is there any reason for this change? - Xinyu Liu On Oct. 30, 2015, 7:09 a.m., N

<    1   2   3