To reply, visit:
https://reviews.apache.org/r/48182/#review136335
-------
On June 9, 2016, 12:33 a.m., Xinyu Liu wrote:
>
> ---
> This is an automatically generated e-mail.
tests and local deployment.
Thanks,
Xinyu Liu
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48213/#review136654
---
On June 8, 2016, 11:53 p.m., Xinyu Liu wrote:
>
> ---
/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala
8e32bba6ced090f0fc8d4e5176fe0788df36981d
Diff: https://reviews.apache.org/r/48213/diff/
Testing
---
Unit tests and local testing.
Thanks,
Xinyu Liu
/scala/org/apache/samza/system/TestSystemConsumers.scala
09da62e0f9a10f7c3683345a309c6278ff01fb4b
Diff: https://reviews.apache.org/r/48243/diff/
Testing
---
unit tests and local testing.
Thanks,
Xinyu Liu
04c9113fd6c3dd56c49ff46c8c1c0ff12f68e5e2
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala
8e32bba6ced090f0fc8d4e5176fe0788df36981d
Diff: https://reviews.apache.org/r/48213/diff/
Testing
---
Unit tests and local testing.
Thanks,
Xinyu Liu
/TestKafkaSystemProducer.scala
8e32bba6ced090f0fc8d4e5176fe0788df36981d
Diff: https://reviews.apache.org/r/48213/diff/
Testing
---
Unit tests and local testing.
Thanks,
Xinyu Liu
This is awesome! Samza will be able to run standalone or on different kinds
of clusters, which can serve a wide range of applications. Glad to see this
is happening.
Thanks,
Xinyu
On Tue, Mar 1, 2016 at 8:48 AM, Jagadish Venkatraman wrote:
> Hi all,
>
> Currently, the
essage. But this average also includes time taken to process null
> messages. So I don't trust the accuracy of that metric.
>
> Each metric emitted by Samza contains a header which includes job name,
> job
> id, container name and metric timestamp. You can use it to calculate
> messag
Hi, David,
I didn't find a wiki page that contains the descriptions of all Samza
metrics. You can find the basic metrics by googling the following classes:
SamzaContainerMetrics, TaskInstanceMetrics, SystemConsumersMetrics and
SystemProducersMetrics. For your example, you can use the
ception.java
(line 27)
<https://reviews.apache.org/r/43350/#comment181838>
is serialVersionUID needed here? If so please use the autogenerated one.
- Xinyu Liu
On Feb. 23, 2016, 9:43 p.m., Jake Maes wrote:
>
> ---
&g
-kafka/src/main/scala/org/apache/samza/util/KafkaUtil.scala (line 162)
<https://reviews.apache.org/r/43053/#comment178367>
nitpick: the var name of "msg1" seems not very well chosen. Shall we do
warn(msg + "...") instead?
- Xinyu Liu
On Feb. 1, 2016, 6:25
/41912/diff/
Testing
---
Unit tests added to cover all the new methods/classes.
Thanks,
Xinyu Liu
+1 on my side. I also ran the gradle build and unit tests without failure.
Thanks,
Xinyu
On Wed, Dec 9, 2015 at 9:54 AM, Tao Feng wrote:
> +1 from my side(non-binding). I download the package and successfully run
> all the unit tests without failure.
>
> On Tue, Dec 8,
ing
---
Thanks,
Xinyu Liu
> On Oct. 30, 2015, 6:06 p.m., Xinyu Liu wrote:
> > samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala,
> > line 132
> > <https://reviews.apache.org/r/39806/diff/1/?file=1112956#file1112956line132>
> >
> > I think sc
123)
<https://reviews.apache.org/r/39806/#comment162817>
I think scala prefers to use the companion object as the factory to create
new instance (code before change). Is there any reason for this change?
- Xinyu Liu
On Oct. 30, 2015, 7:09 a.m., N
201 - 217 of 217 matches
Mail list logo