Re: Review Request 51633: SAMZA-1013: Add YARN Node label support

2016-10-20 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51633/#review153465 --- Ship it! - Jagadish Venkatraman On Oct. 7, 2016, 12:08 a.m.,

Re: Review Request 51633: SAMZA-1013: Add YARN Node label support

2016-10-06 Thread Jagadish Venkatraman
> On Oct. 5, 2016, 6:18 p.m., Jagadish Venkatraman wrote: > > Overall, the patch looks great! This is exciting given that Samza can > > support scheduling based on tags. For example, jobs with rocksdb can be > > assigned to nodes with SSDs. > > > > > > Can you please add some detail on

Re: Review Request 51633: SAMZA-1013: Add YARN Node label support

2016-10-06 Thread Maxim Logvinenko
> On Oct. 5, 2016, 6:18 p.m., Jagadish Venkatraman wrote: > > samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnClusterResourceManager.java, > > line 187 > > > > > > nit: containerLabel so that we distinguish

Re: Review Request 51633: SAMZA-1013: Add YARN Node label support

2016-10-06 Thread Maxim Logvinenko
> On Oct. 5, 2016, 6:18 p.m., Jagadish Venkatraman wrote: > > Overall, the patch looks great! This is exciting given that Samza can > > support scheduling based on tags. For example, jobs with rocksdb can be > > assigned to nodes with SSDs. > > > > > > Can you please add some detail on

Re: Review Request 51633: SAMZA-1013: Add YARN Node label support

2016-10-06 Thread Maxim Logvinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51633/ --- (Updated Oct. 7, 2016, 12:08 a.m.) Review request for samza. Changes ---

Re: Review Request 51633: SAMZA-1013: Add YARN Node label support

2016-10-05 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51633/#review151519 --- Overall, the patch looks great! This is exciting given that Samza