[GitHub] Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-20 Thread GitBox
Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258676318 ## File path: samza-core/src/test/java/org/apache/samza/runtime/TestLocalApplicationRunner.java ## @@

[GitHub] Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-20 Thread GitBox
Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258676212 ## File path: samza-core/src/main/java/org/apache/samza/execution/JobPlanner.java ## @@ -155,4 +158,33 @@

[GitHub] Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-20 Thread GitBox
Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258676267 ## File path: samza-test/src/main/java/org/apache/samza/test/framework/TestRunner.java ## @@ -104,7

[GitHub] Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-20 Thread GitBox
Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258676142 ## File path:

[GitHub] Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-19 Thread GitBox
Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258288145 ## File path: samza-core/src/main/java/org/apache/samza/execution/JobPlanner.java ## @@ -155,4 +158,33 @@