Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

2016-06-09 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48182/#review136879 --- Ship it! Ship It! - Chris Pettitt On June 9, 2016, 12:33

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

2016-06-09 Thread Chris Pettitt
> On June 9, 2016, 12:28 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala, > > line 90 > > > > > > This is a test that Xinyu

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

2016-06-08 Thread Xinyu Liu
> On June 6, 2016, 6:22 p.m., Chris Pettitt wrote: > > samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala, > > line 528 > > > > > > How about actually capturing the test failure and

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

2016-06-08 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48182/ --- (Updated June 9, 2016, 12:33 a.m.) Review request for samza, Chris Pettitt,

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

2016-06-08 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48182/#review136735 --- Ship it!

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

2016-06-06 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48182/#review136335 --- Fix it, then Ship it!

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

2016-06-03 Thread Chris Pettitt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48182/#review136075 --- Fix it, then Ship it!