Re: [sc-dev] About issue25018

2008-07-18 Thread Daniel Rentz
yunjingtao schrieb: Daniel schrieb: Please do not rely on the item state only, but test the contents of the item too. See the example for the FID_MERGE_TOGGLE item in the same file: the test ... = SFX_ITEM_DEFAULT makes sure that the item exists (it has state DEFAULT or SET), and that it

Re: Re: [sc-dev] About issue25018

2008-07-17 Thread yunjingtao
Daniel schrieb: Please do not rely on the item state only, but test the contents of the item too. See the example for the FID_MERGE_TOGGLE item in the same file: the test ... = SFX_ITEM_DEFAULT makes sure that the item exists (it has state DEFAULT or SET), and that it is possible to use the

Re: [sc-dev] About issue25018

2008-07-14 Thread Daniel Rentz
yunjingtao schrieb: hi, Daniel I submitted a patch to issue25018. Using some test cases, I checked it, and it's ok. Hope you review it, and if possible,give me some advice. If there is no problem with it, assign me issues please. I have one question and wish you answer it at your