[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r240015539 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/ESDriverTest.java ## @@ -0,0 +1,265 @@ +/*

[GitHub] quintinali commented on issue #35: SDAP-161 MUDROD embedded unit test

quintinali commented on issue #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#issuecomment-445361213 @lewismc I solved most issued based on your comments. Could you please take a look at my explanation when you have time, especially fo

[GitHub] quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239940986 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java #

[GitHub] quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239940404 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java #

[GitHub] quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239940478 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java #

[GitHub] quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239940191 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java #

[GitHub] quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239939252 ## File path: core/src/main/java/org/apache/sdap/mudrod/weblog/pre/SessionStatistic.java ## @@ -229

[GitHub] quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239938525 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/TestMudrodEngine.java ## @@ -23,9 +23,9

[GitHub] quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239937349 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/AbstractElasticsearchIntegrationTest.java #

[GitHub] quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239933865 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java #

[GitHub] quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239931381 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java #

[GitHub] quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239869585 ## File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java ## @@ -391,12 +391,12

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239542280 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/ESDriverTest.java ## @@ -0,0 +1,312 @@ +/*

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239539235 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239540790 ## File path: core/src/test/java/org/apache/sdap/mudrod/driver/EmbeddedElasticsearchServer.java ## @@

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239542736 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/TestMudrodEngine.java ## @@ -23,9 +23,9 @@

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239541881 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/ESDriverTest.java ## @@ -0,0 +1,312 @@ +/*

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239538581 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239540539 ## File path: core/src/test/java/org/apache/sdap/mudrod/driver/EmbeddedElasticsearchServer.java ## @@

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239541940 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/ESDriverTest.java ## @@ -0,0 +1,312 @@ +/*

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239541715 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/AbstractElasticsearchIntegrationTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239542355 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/ESDriverTest.java ## @@ -0,0 +1,312 @@ +/*

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239539469 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239539163 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239538180 ## File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java ## @@ -391,12 +391,12 @@

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239539629 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239538820 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239541079 ## File path: core/src/test/java/org/apache/sdap/mudrod/driver/PluginConfigurableNode.java ## @@ -0,0

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239541560 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/AbstractElasticsearchIntegrationTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239538277 ## File path: core/src/main/java/org/apache/sdap/mudrod/weblog/pre/SessionStatistic.java ## @@ -229,7

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239538351 ## File path: core/src/main/java/org/apache/sdap/mudrod/weblog/structure/session/SessionTree.java ## @

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239540151 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239541170 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/AbstractElasticsearchIntegrationTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239537668 ## File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java ## @@ -391,12 +391,12 @@

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239543206 ## File path: core/src/test/java/org/apache/sdap/mudrod/weblog/structure/log/GeoIpTest.java ## @@ -0,0

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239538523 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] quintinali commented on issue #35: SDAP-161 MUDROD embedded unit test

quintinali commented on issue #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#issuecomment-444932257 @lewismc I revised the code as you required. Could you please take a look at the unit test cases and please let me know whether they are

[GitHub] quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238318734 ## File path: core/src/test/java/org/apache/sdap/mudrod/weblog/structure/log/GeoIpTest.java ## @@ -

[GitHub] quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238313448 ## File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java ## @@ -391,12 +391,12

[GitHub] quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238314526 ## File path: core/src/main/java/org/apache/sdap/mudrod/weblog/pre/SessionStatistic.java ## @@ -229

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238033346 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238033834 ## File path: core/src/test/java/org/apache/sdap/mudrod/driver/PluginConfigurableNode.java ## @@ -0,0

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238033850 ## File path: core/src/test/java/org/apache/sdap/mudrod/driver/PluginConfigurableNode.java ## @@ -0,0

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238033999 ## File path: core/src/test/java/org/apache/sdap/mudrod/weblog/structure/RequestUrlTest.java ## @@ -0,

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238033357 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238034514 ## File path: core/src/test/java/org/apache/sdap/mudrod/weblog/structure/log/GeoIpTest.java ## @@ -0,0

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238033924 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/AbstractElasticsearchIntegrationTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238032872 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238032419 ## File path: core/src/main/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngine.java ##

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238034160 ## File path: core/src/test/java/org/apache/sdap/mudrod/weblog/structure/log/GeoIpTest.java ## @@ -0,0

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238032465 ## File path: core/src/main/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngine.java ##

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238033243 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238032781 ## File path: core/src/main/java/org/apache/sdap/mudrod/weblog/structure/session/SessionTree.java ## @

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238034551 ## File path: core/src/test/java/org/apache/sdap/mudrod/weblog/structure/log/GeoIpTest.java ## @@ -0,0

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238032665 ## File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java ## @@ -391,12 +391,12 @@

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238034020 ## File path: core/src/test/java/org/apache/sdap/mudrod/weblog/structure/RequestUrlTest.java ## @@ -0,

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238034053 ## File path: core/src/test/java/org/apache/sdap/mudrod/weblog/structure/RequestUrlTest.java ## @@ -0,

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238032746 ## File path: core/src/main/java/org/apache/sdap/mudrod/weblog/pre/SessionStatistic.java ## @@ -229,7

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238034104 ## File path: core/src/test/java/org/apache/sdap/mudrod/weblog/structure/RequestUrlTest.java ## @@ -0,

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238033014 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238033385 ## File path: core/src/test/java/org/apache/sdap/mudrod/driver/EmbeddedElasticsearchServer.java ## @@

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238032482 ## File path: core/src/main/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngine.java ##

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238034182 ## File path: core/src/test/java/org/apache/sdap/mudrod/weblog/structure/log/GeoIpTest.java ## @@ -0,0

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238033873 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/AbstractElasticsearchIntegrationTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238032627 ## File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java ## @@ -391,12 +391,12 @@

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r238032819 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] quintinali commented on issue #35: Sdap 161

quintinali commented on issue #35: Sdap 161 URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#issuecomment-443366045 @fgreg @lewismc Could you please take a look at the code. As I mentioned in the last meeting, the EmbeddedElasticsearchServer can not work in the code and I can

[GitHub] quintinali opened a new pull request #35: Sdap 161

quintinali opened a new pull request #35: Sdap 161 URL: https://github.com/apache/incubator-sdap-mudrod/pull/35 test case for log ingestion and preprocessing This is an automated message from the Apache Git Service. To respond

[GitHub] asfgit commented on issue #35: Sdap 161

asfgit commented on issue #35: Sdap 161 URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#issuecomment-443365249 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] fgreg closed pull request #60: SDAP-151 Determine parallelism automatically for Spark analytics (#50)

fgreg closed pull request #60: SDAP-151 Determine parallelism automatically for Spark analytics (#50) URL: https://github.com/apache/incubator-sdap-nexus/pull/60 This is an automated message from the Apache Git Service. To r

[GitHub] fgreg opened a new pull request #60: SDAP-151 Determine parallelism automatically for Spark analytics (#50)

fgreg opened a new pull request #60: SDAP-151 Determine parallelism automatically for Spark analytics (#50) URL: https://github.com/apache/incubator-sdap-nexus/pull/60 * Removed spark configuration, added nparts configuration, and autocompute parallelism for spark-based time series.

[GitHub] mayadebellis closed pull request #59: Merge pull request #1 from apache/master

mayadebellis closed pull request #59: Merge pull request #1 from apache/master URL: https://github.com/apache/incubator-sdap-nexus/pull/59 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] jjacob7734 closed pull request #50: SDAP-151 Determine parallelism automatically for Spark analytics

jjacob7734 closed pull request #50: SDAP-151 Determine parallelism automatically for Spark analytics URL: https://github.com/apache/incubator-sdap-nexus/pull/50 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] fgreg closed pull request #55: SDAP-164 Refactor Webapp

fgreg closed pull request #55: SDAP-164 Refactor Webapp URL: https://github.com/apache/incubator-sdap-nexus/pull/55 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] fgreg opened a new pull request #55: SDAP-164 Refactor Webapp

fgreg opened a new pull request #55: SDAP-164 Refactor Webapp URL: https://github.com/apache/incubator-sdap-nexus/pull/55 Allows for a multi-process webapp so we can better handle simultaneous requests. This is an automated m

[GitHub] lewismc commented on a change in pull request #34: SDAP-165 Fix MUDROD bugs to get master branch running

lewismc commented on a change in pull request #34: SDAP-165 Fix MUDROD bugs to get master branch running URL: https://github.com/apache/incubator-sdap-mudrod/pull/34#discussion_r231742380 ## File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java ## @@

[GitHub] fgreg closed pull request #34: SDAP-165 Fix MUDROD bugs to get master branch running

fgreg closed pull request #34: SDAP-165 Fix MUDROD bugs to get master branch running URL: https://github.com/apache/incubator-sdap-mudrod/pull/34 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] fgreg closed pull request #54: Fixing merge conflicts

fgreg closed pull request #54: Fixing merge conflicts URL: https://github.com/apache/incubator-sdap-nexus/pull/54 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (

[GitHub] fgreg opened a new pull request #54: Fixing merge conflicts

fgreg opened a new pull request #54: Fixing merge conflicts URL: https://github.com/apache/incubator-sdap-nexus/pull/54 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] fgreg closed pull request #53: Fixing merge conflicts with master

fgreg closed pull request #53: Fixing merge conflicts with master URL: https://github.com/apache/incubator-sdap-nexus/pull/53 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[GitHub] fgreg opened a new pull request #53: Fixing merge conflicts with master

fgreg opened a new pull request #53: Fixing merge conflicts with master URL: https://github.com/apache/incubator-sdap-nexus/pull/53 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] fgreg opened a new pull request #52: SDAP-149: Generate images directly from data

fgreg opened a new pull request #52: SDAP-149: Generate images directly from data URL: https://github.com/apache/incubator-sdap-nexus/pull/52 This PR is for integrating the image changes into master. This is an automated mess

[GitHub] kmgill commented on issue #48: SDAP-158 changes from SDAP-149 + Spark imaging algorithms

kmgill commented on issue #48: SDAP-158 changes from SDAP-149 + Spark imaging algorithms URL: https://github.com/apache/incubator-sdap-nexus/pull/48#issuecomment-436713691 Maya, please merge this to my fork first This is an

[GitHub] asfgit commented on issue #34: Sdap 165

asfgit commented on issue #34: Sdap 165 URL: https://github.com/apache/incubator-sdap-mudrod/pull/34#issuecomment-436705093 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] echyam opened a new pull request #34: Sdap 165

echyam opened a new pull request #34: Sdap 165 URL: https://github.com/apache/incubator-sdap-mudrod/pull/34 The current master branch doesn't build. This fixes missing imports, expected log filename formats, and gets rid of printing cli options when catching generic exception

[GitHub] fgreg closed pull request #51: SDAP-137 Webapp should have a mesos and a standalone image

fgreg closed pull request #51: SDAP-137 Webapp should have a mesos and a standalone image URL: https://github.com/apache/incubator-sdap-nexus/pull/51 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] fgreg closed pull request #49: SDAP-149 Generate images directly from data

fgreg closed pull request #49: SDAP-149 Generate images directly from data URL: https://github.com/apache/incubator-sdap-nexus/pull/49 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a f

[GitHub] fgreg opened a new pull request #51: SDAP-137 Webapp should have a mesos and a standalone image

fgreg opened a new pull request #51: SDAP-137 Webapp should have a mesos and a standalone image URL: https://github.com/apache/incubator-sdap-nexus/pull/51 This is an automated message from the Apache Git Service. To respond

[GitHub] jjacob7734 opened a new pull request #50: SDAP-151 Determine parallelism automatically for Spark analytics

jjacob7734 opened a new pull request #50: SDAP-151 Determine parallelism automatically for Spark analytics URL: https://github.com/apache/incubator-sdap-nexus/pull/50 The built-in NEXUS analytics timeSeriesSpark, timeAvgMapSpark, corrMapSpark, and climMapSpark got the desired parallelism f

[GitHub] kmgill opened a new pull request #49: Merge of latest from SDAP-149

kmgill opened a new pull request #49: Merge of latest from SDAP-149 URL: https://github.com/apache/incubator-sdap-nexus/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] fgreg closed pull request #10: SDAP-155 add processor to extract timestamp from granule metadata

fgreg closed pull request #10: SDAP-155 add processor to extract timestamp from granule metadata URL: https://github.com/apache/incubator-sdap-ningesterpy/pull/10 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake o

[GitHub] fgreg commented on a change in pull request #48: SDAP-158 changes from SDAP-149 + Spark imaging algorithms

fgreg commented on a change in pull request #48: SDAP-158 changes from SDAP-149 + Spark imaging algorithms URL: https://github.com/apache/incubator-sdap-nexus/pull/48#discussion_r227468422 ## File path: analysis/webservice/algorithms/imaging/mapprocessingSpark.py ## @@ -0

[GitHub] fgreg commented on a change in pull request #48: SDAP-158 changes from SDAP-149 + Spark imaging algorithms

fgreg commented on a change in pull request #48: SDAP-158 changes from SDAP-149 + Spark imaging algorithms URL: https://github.com/apache/incubator-sdap-nexus/pull/48#discussion_r227466397 ## File path: analysis/webservice/algorithms/imaging/mapprocessingSpark.py ## @@ -0

[GitHub] fgreg commented on a change in pull request #48: SDAP-158 changes from SDAP-149 + Spark imaging algorithms

fgreg commented on a change in pull request #48: SDAP-158 changes from SDAP-149 + Spark imaging algorithms URL: https://github.com/apache/incubator-sdap-nexus/pull/48#discussion_r227463070 ## File path: analysis/webservice/algorithms/imaging/mapprocessingSpark.py ## @@ -0

[GitHub] fgreg commented on a change in pull request #48: SDAP-158 changes from SDAP-149 + Spark imaging algorithms

fgreg commented on a change in pull request #48: SDAP-158 changes from SDAP-149 + Spark imaging algorithms URL: https://github.com/apache/incubator-sdap-nexus/pull/48#discussion_r227467305 ## File path: analysis/webservice/algorithms/imaging/mapprocessingSpark.py ## @@ -0

[GitHub] fgreg commented on a change in pull request #10: SDAP-155 add processor to extract timestamp from granule metadata

fgreg commented on a change in pull request #10: SDAP-155 add processor to extract timestamp from granule metadata URL: https://github.com/apache/incubator-sdap-ningesterpy/pull/10#discussion_r227453950 ## File path: sdap/processors/extracttimestampprocessor.py ## @@ -0,0

[GitHub] fgreg commented on a change in pull request #10: SDAP-155 add processor to extract timestamp from granule metadata

fgreg commented on a change in pull request #10: SDAP-155 add processor to extract timestamp from granule metadata URL: https://github.com/apache/incubator-sdap-ningesterpy/pull/10#discussion_r227167036 ## File path: sdap/processors/extracttimestampprocessor.py ## @@ -0,0

[GitHub] echyam commented on a change in pull request #10: SDAP-155 add processor to extract timestamp from granule metadata

echyam commented on a change in pull request #10: SDAP-155 add processor to extract timestamp from granule metadata URL: https://github.com/apache/incubator-sdap-ningesterpy/pull/10#discussion_r227165943 ## File path: sdap/processors/extracttimestampprocessor.py ## @@ -0,

[GitHub] echyam commented on a change in pull request #10: SDAP-155 add processor to extract timestamp from granule metadata

echyam commented on a change in pull request #10: SDAP-155 add processor to extract timestamp from granule metadata URL: https://github.com/apache/incubator-sdap-ningesterpy/pull/10#discussion_r227165341 ## File path: sdap/processors/extracttimestampprocessor.py ## @@ -0,

[GitHub] mayadebellis opened a new pull request #48: SDAP-158 changes from SDAP-149 + Spark imaging algorithms

mayadebellis opened a new pull request #48: SDAP-158 changes from SDAP-149 + Spark imaging algorithms URL: https://github.com/apache/incubator-sdap-nexus/pull/48 This is an automated message from the Apache Git Service. To r

<    5   6   7   8   9   10   11   12   13   14   >