[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711657#comment-16711657 ] ASF GitHub Bot commented on SDAP-161: - quintinali commented on issue #35: SDAP-161 MUDROD embedded unit

[GitHub] quintinali commented on issue #35: SDAP-161 MUDROD embedded unit test

quintinali commented on issue #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#issuecomment-444932257 @lewismc I revised the code as you required. Could you please take a look at the unit test cases and please let me know whether they

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711757#comment-16711757 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711756#comment-16711756 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711748#comment-16711748 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711736#comment-16711736 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711738#comment-16711738 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239541079 ## File path: core/src/test/java/org/apache/sdap/mudrod/driver/PluginConfigurableNode.java ## @@ -0,0

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239542355 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/ESDriverTest.java ## @@ -0,0 +1,312 @@

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239539469 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239539163 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239538180 ## File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java ## @@ -391,12 +391,12

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239539629 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239541560 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/AbstractElasticsearchIntegrationTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239538820 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711739#comment-16711739 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711750#comment-16711750 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711744#comment-16711744 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711740#comment-16711740 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711746#comment-16711746 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239538277 ## File path: core/src/main/java/org/apache/sdap/mudrod/weblog/pre/SessionStatistic.java ## @@ -229,7

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239538351 ## File path: core/src/main/java/org/apache/sdap/mudrod/weblog/structure/session/SessionTree.java ##

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239540151 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239541170 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/AbstractElasticsearchIntegrationTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239537668 ## File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java ## @@ -391,12 +391,12

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239543206 ## File path: core/src/test/java/org/apache/sdap/mudrod/weblog/structure/log/GeoIpTest.java ## @@

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711755#comment-16711755 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711749#comment-16711749 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711745#comment-16711745 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711741#comment-16711741 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711737#comment-16711737 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711754#comment-16711754 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711759#comment-16711759 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711747#comment-16711747 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711742#comment-16711742 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239541715 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/AbstractElasticsearchIntegrationTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239538581 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239540539 ## File path: core/src/test/java/org/apache/sdap/mudrod/driver/EmbeddedElasticsearchServer.java ## @@

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239541940 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/ESDriverTest.java ## @@ -0,0 +1,312 @@

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239542280 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/ESDriverTest.java ## @@ -0,0 +1,312 @@

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239539235 ## File path: core/src/test/java/org/apache/sdap/mudrod/discoveryengine/WeblogDiscoveryEngineTest.java

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239540790 ## File path: core/src/test/java/org/apache/sdap/mudrod/driver/EmbeddedElasticsearchServer.java ## @@

[GitHub] lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r239542736 ## File path: core/src/test/java/org/apache/sdap/mudrod/main/TestMudrodEngine.java ## @@ -23,9 +23,9

[jira] [Commented] (SDAP-161) MUDROD embedded unit test

[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711753#comment-16711753 ] ASF GitHub Bot commented on SDAP-161: - lewismc commented on a change in pull request #35: SDAP-161