[GitHub] lewismc commented on issue #21: fixed bugs in SessionGenerator.java

2018-05-17 Thread GitBox
lewismc commented on issue #21: fixed bugs in SessionGenerator.java URL: https://github.com/apache/incubator-sdap-mudrod/pull/21#issuecomment-390093836 +1 This is an automated message from the Apache Git Service. To respond

[GitHub] lewismc commented on issue #20: fixed bugs in sessionstatistic.java

2018-05-17 Thread GitBox
lewismc commented on issue #20: fixed bugs in sessionstatistic.java URL: https://github.com/apache/incubator-sdap-mudrod/pull/20#issuecomment-390093763 +1 please quash and merge This is an automated message from the Apache

[GitHub] quintinali opened a new pull request #21: fixed bugs in SessionGenerator.java

2018-05-17 Thread GitBox
quintinali opened a new pull request #21: fixed bugs in SessionGenerator.java URL: https://github.com/apache/incubator-sdap-mudrod/pull/21 1. Add code in InterruptedException 2. Cast one of the operands of the division operation to a "double".

[GitHub] asfgit commented on issue #21: fixed bugs in SessionGenerator.java

2018-05-17 Thread GitBox
asfgit commented on issue #21: fixed bugs in SessionGenerator.java URL: https://github.com/apache/incubator-sdap-mudrod/pull/21#issuecomment-390076174 Can one of the admins verify this patch? This is an automated message

[GitHub] quintinali opened a new pull request #20: fixed bugs in sessionstatistic.java

2018-05-17 Thread GitBox
quintinali opened a new pull request #20: fixed bugs in sessionstatistic.java URL: https://github.com/apache/incubator-sdap-mudrod/pull/20 "InterruptedException" should not be ignored This is an automated message from the

[GitHub] asfgit commented on issue #20: fixed bugs in sessionstatistic.java

2018-05-17 Thread GitBox
asfgit commented on issue #20: fixed bugs in sessionstatistic.java URL: https://github.com/apache/incubator-sdap-mudrod/pull/20#issuecomment-390075994 Can one of the admins verify this patch? This is an automated message

[jira] [Commented] (SDAP-72) Fix bugs in ESDriver.java

2018-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480036#comment-16480036 ] ASF GitHub Bot commented on SDAP-72: quintinali commented on issue #17: SDAP-72 URL:

[GitHub] quintinali commented on issue #17: SDAP-72

2018-05-17 Thread GitBox
quintinali commented on issue #17: SDAP-72 URL: https://github.com/apache/incubator-sdap-mudrod/pull/17#issuecomment-390074295 @lewismc Yes, I still have issues with the try-with-resources. If I create ESTransportClient using try-with-resources as follow, an error occurs. ```

[jira] [Commented] (SDAP-72) Fix bugs in ESDriver.java

2018-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480030#comment-16480030 ] ASF GitHub Bot commented on SDAP-72: quintinali commented on issue #17: SDAP-72 URL:

[GitHub] quintinali commented on issue #17: SDAP-72

2018-05-17 Thread GitBox
quintinali commented on issue #17: SDAP-72 URL: https://github.com/apache/incubator-sdap-mudrod/pull/17#issuecomment-390074295 @lewismc Yes, I still have issues with the try-with-resources. If I create ESTransportClient using try-with-resources as follow, an error occurs. `

[GitHub] quintinali commented on issue #17: SDAP-72

2018-05-17 Thread GitBox
quintinali commented on issue #17: SDAP-72 URL: https://github.com/apache/incubator-sdap-mudrod/pull/17#issuecomment-390074295 @lewismc Yes, I still have issues with the try-with-resources. If I create ESTransportClient using try-with-resources as follow, an error occurs. `if

[GitHub] quintinali closed pull request #19: SDAP-74

2018-05-17 Thread GitBox
quintinali closed pull request #19: SDAP-74 URL: https://github.com/apache/incubator-sdap-mudrod/pull/19 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[jira] [Commented] (SDAP-72) Fix bugs in ESDriver.java

2018-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479973#comment-16479973 ] ASF GitHub Bot commented on SDAP-72: lewismc commented on issue #17: SDAP-72 URL:

[GitHub] lewismc commented on issue #17: SDAP-72

2018-05-17 Thread GitBox
lewismc commented on issue #17: SDAP-72 URL: https://github.com/apache/incubator-sdap-mudrod/pull/17#issuecomment-390063551 Are you still having issues with the try-with-resources? This is an automated message from the

[GitHub] lewismc commented on a change in pull request #18: SDAP-73

2018-05-17 Thread GitBox
lewismc commented on a change in pull request #18: SDAP-73 URL: https://github.com/apache/incubator-sdap-mudrod/pull/18#discussion_r189141858 ## File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java ## @@ -173,34 +173,35 @@ private String

[jira] [Commented] (SDAP-73) Fix bugs in MudrodEngine.java

2018-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479972#comment-16479972 ] ASF GitHub Bot commented on SDAP-73: lewismc commented on a change in pull request #18: SDAP-73 URL:

[jira] [Commented] (SDAP-74) Fix bugs in RecommendEngine.java

2018-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479968#comment-16479968 ] ASF GitHub Bot commented on SDAP-74: lewismc commented on issue #19: SDAP-74 URL:

[jira] [Updated] (SDAP-78) Fix bugs in HistoryGenerator.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-78: --- Description:  Fix bugs found in HistoryGenerator.java @[~lewismc]  > Fix bugs in HistoryGenerator.java >

[jira] [Updated] (SDAP-78) Fix bugs in HistoryGenerator.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-78: --- Component/s: mudrod > Fix bugs in HistoryGenerator.java > - > > Key:

[jira] [Created] (SDAP-78) Fix bugs in HistoryGenerator.java

2018-05-17 Thread Yun Li (JIRA)
Yun Li created SDAP-78: -- Summary: Fix bugs in HistoryGenerator.java Key: SDAP-78 URL: https://issues.apache.org/jira/browse/SDAP-78 Project: Apache Science Data Analytics Platform Issue Type: Bug

[jira] [Updated] (SDAP-77) Fix bugs in SessionGenerator.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-77: --- Description:   Fix bugs found in SessionGenerator.java @[~lewismc]  > Fix bugs in SessionGenerator.java >

[jira] [Updated] (SDAP-77) Fix bugs in SessionGenerator.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-77: --- Fix Version/s: 0.1 > Fix bugs in SessionGenerator.java > - > > Key:

[jira] [Updated] (SDAP-76) Fix bugs in SessionStatistic.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-76: --- Component/s: mudrod > Fix bugs in SessionStatistic.java > - > > Key:

[jira] [Updated] (SDAP-76) Fix bugs in SessionStatistic.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-76: --- Description: Solve bugs found in SessionStatistic.java @[~lewismc]  was: Solve bugs found in MudrodEngine.java

[jira] [Updated] (SDAP-76) Fix bugs in SessionStatistic.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-76: --- Description: Solve bugs found in MudrodEngine.java @[~lewismc]  > Fix bugs in SessionStatistic.java >

[jira] [Created] (SDAP-76) Fix bugs in SessionStatistic.java

2018-05-17 Thread Yun Li (JIRA)
Yun Li created SDAP-76: -- Summary: Fix bugs in SessionStatistic.java Key: SDAP-76 URL: https://issues.apache.org/jira/browse/SDAP-76 Project: Apache Science Data Analytics Platform Issue Type: Bug

[jira] [Updated] (SDAP-73) Fix bugs in MudrodEngine.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-73: --- Summary: Fix bugs in MudrodEngine.java (was: Solve bugs in MudrodEngine.java) > Fix bugs in MudrodEngine.java >

[jira] [Updated] (SDAP-72) Fix bugs in ESDriver.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-72: --- Summary: Fix bugs in ESDriver.java (was: Solve bugs in file named ESDriver) > Fix bugs in ESDriver.java >

[jira] [Updated] (SDAP-75) Fix bugs in AggregateTriples.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-75: --- Description: Fix bugs found in AggregateTriple by sonar coverage @[~lewismc]  > Fix bugs in AggregateTriples.java >

[jira] [Updated] (SDAP-75) Fix bugs in AggregateTriples.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-75: --- Fix Version/s: 0.1 > Fix bugs in AggregateTriples.java > - > > Key:

[jira] [Created] (SDAP-75) Fix bugs in AggregateTriples.java

2018-05-17 Thread Yun Li (JIRA)
Yun Li created SDAP-75: -- Summary: Fix bugs in AggregateTriples.java Key: SDAP-75 URL: https://issues.apache.org/jira/browse/SDAP-75 Project: Apache Science Data Analytics Platform Issue Type: Bug

[GitHub] asfgit commented on issue #19: SDAP-74

2018-05-17 Thread GitBox
asfgit commented on issue #19: SDAP-74 URL: https://github.com/apache/incubator-sdap-mudrod/pull/19#issuecomment-390030587 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[jira] [Commented] (SDAP-74) Fix bugs in RecommendEngine.java

2018-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479811#comment-16479811 ] ASF GitHub Bot commented on SDAP-74: quintinali opened a new pull request #19: SDAP-74 URL:

[GitHub] quintinali opened a new pull request #19: SDAP-74

2018-05-17 Thread GitBox
quintinali opened a new pull request #19: SDAP-74 URL: https://github.com/apache/incubator-sdap-mudrod/pull/19 Fixed not enough arguments bug when the LOG.info function is invoked This is an automated message from the Apache

[jira] [Updated] (SDAP-74) Fix bugs in RecommendEngine.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-74: --- Description: Fix  bugs found by sonar coverage @[~lewismc]  > Fix bugs in RecommendEngine.java >

[jira] [Updated] (SDAP-74) Fix bugs in RecommendEngine.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-74: --- Description: Fix bugs found in MudrodEngine by sonar coverage @[~lewismc]  (was: Fix  bugs found by sonar coverage

[jira] [Created] (SDAP-74) Fix bugs in RecommendEngine.java

2018-05-17 Thread Yun Li (JIRA)
Yun Li created SDAP-74: -- Summary: Fix bugs in RecommendEngine.java Key: SDAP-74 URL: https://issues.apache.org/jira/browse/SDAP-74 Project: Apache Science Data Analytics Platform Issue Type: Bug

[jira] [Updated] (SDAP-74) Fix bugs in RecommendEngine.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-74: --- Component/s: mudrod > Fix bugs in RecommendEngine.java > > > Key:

[jira] [Updated] (SDAP-74) Fix bugs in RecommendEngine.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-74: --- Fix Version/s: 0.1 > Fix bugs in RecommendEngine.java > > > Key:

[GitHub] quintinali opened a new pull request #18: SDAP-73

2018-05-17 Thread GitBox
quintinali opened a new pull request #18: SDAP-73 URL: https://github.com/apache/incubator-sdap-mudrod/pull/18 Fixed bugs in MudrodEngine.java 1.Modify this "assert" statement. 2.Use try-with-resources to close ZipInputStream

[jira] [Commented] (SDAP-72) Solve bugs in file named ESDriver

2018-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479748#comment-16479748 ] ASF GitHub Bot commented on SDAP-72: lewismc commented on a change in pull request #17: SDAP-72 URL:

[jira] [Commented] (SDAP-72) Solve bugs in file named ESDriver

2018-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479747#comment-16479747 ] ASF GitHub Bot commented on SDAP-72: lewismc commented on a change in pull request #17: SDAP-72 URL:

[jira] [Commented] (SDAP-72) Solve bugs in file named ESDriver

2018-05-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479729#comment-16479729 ] ASF GitHub Bot commented on SDAP-72: quintinali opened a new pull request #17: SDAP-72 URL:

[GitHub] lewismc commented on a change in pull request #17: SDAP-72

2018-05-17 Thread GitBox
lewismc commented on a change in pull request #17: SDAP-72 URL: https://github.com/apache/incubator-sdap-mudrod/pull/17#discussion_r189106493 ## File path: core/src/main/java/org/apache/sdap/mudrod/driver/ESDriver.java ## @@ -473,12 +474,20 @@ protected Client

[GitHub] lewismc commented on a change in pull request #17: SDAP-72

2018-05-17 Thread GitBox
lewismc commented on a change in pull request #17: SDAP-72 URL: https://github.com/apache/incubator-sdap-mudrod/pull/17#discussion_r189106849 ## File path: core/src/main/java/org/apache/sdap/mudrod/driver/ESDriver.java ## @@ -473,12 +474,20 @@ protected Client

[GitHub] lewismc commented on a change in pull request #17: SDAP-72

2018-05-17 Thread GitBox
lewismc commented on a change in pull request #17: SDAP-72 URL: https://github.com/apache/incubator-sdap-mudrod/pull/17#discussion_r189106719 ## File path: core/src/main/java/org/apache/sdap/mudrod/driver/ESDriver.java ## @@ -473,12 +474,20 @@ protected Client

[jira] [Updated] (SDAP-73) Solve bugs in MudrodEngine.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-73: --- Description: Solve bugs found in MudrodEngine.java @[~lewismc]  > Solve bugs in MudrodEngine.java >

[jira] [Updated] (SDAP-73) Solve bugs in MudrodEngine.java

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-73: --- Fix Version/s: 0.1 > Solve bugs in MudrodEngine.java > --- > > Key: SDAP-73

[jira] [Created] (SDAP-73) Solve bugs in MudrodEngine.java

2018-05-17 Thread Yun Li (JIRA)
Yun Li created SDAP-73: -- Summary: Solve bugs in MudrodEngine.java Key: SDAP-73 URL: https://issues.apache.org/jira/browse/SDAP-73 Project: Apache Science Data Analytics Platform Issue Type: Bug

[GitHub] quintinali opened a new pull request #17: SDAP-72

2018-05-17 Thread GitBox
quintinali opened a new pull request #17: SDAP-72 URL: https://github.com/apache/incubator-sdap-mudrod/pull/17 Fixed bugs in ESDriver.java (1)"InterruptedException" should not be ignored (2)Use try-with-resources or close this "ESTransportClient" in a "finally" clause.

[GitHub] asfgit commented on issue #17: SDAP-72

2018-05-17 Thread GitBox
asfgit commented on issue #17: SDAP-72 URL: https://github.com/apache/incubator-sdap-mudrod/pull/17#issuecomment-390015738 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[jira] [Updated] (SDAP-72) Solve bugs in file named ESDriver

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-72: --- Summary: Solve bugs in file named ESDriver (was: Solve MUDROD bugs found by sonar coverage) > Solve bugs in file named

[jira] [Updated] (SDAP-72) Solve MUDROD bugs found by sonar coverage

2018-05-17 Thread Lewis John McGibbney (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lewis John McGibbney updated SDAP-72: - Fix Version/s: 0.1 > Solve MUDROD bugs found by sonar coverage >

[jira] [Updated] (SDAP-72) Solve MUDROD bugs found by sonar coverage

2018-05-17 Thread Lewis John McGibbney (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lewis John McGibbney updated SDAP-72: - Component/s: mudrod > Solve MUDROD bugs found by sonar coverage >

[jira] [Commented] (SDAP-72) Solve MUDROD bugs found by sonar coverage

2018-05-17 Thread Lewis John McGibbney (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479568#comment-16479568 ] Lewis John McGibbney commented on SDAP-72: -- [~quintinali] please open a separate ticket for every

[jira] [Commented] (SDAP-72) Solve MUDROD bugs found by sonar coverage

2018-05-17 Thread Lewis John McGibbney (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479569#comment-16479569 ] Lewis John McGibbney commented on SDAP-72: -- Also, tag your issues as I've done for you, thanks >

[jira] [Updated] (SDAP-72) Solve MUDROD bugs found by sonar coverage

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-72: --- Description: Solve MUDROD bugs found by sonar coverage @[~lewismc]  (was: Solve MUDROD bugs found by sonar coverage )

[jira] [Updated] (SDAP-72) Solve MUDROD bugs found by sonar coverage

2018-05-17 Thread Yun Li (JIRA)
[ https://issues.apache.org/jira/browse/SDAP-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Li updated SDAP-72: --- Description: Solve MUDROD bugs found by sonar coverage  > Solve MUDROD bugs found by sonar coverage >

[jira] [Created] (SDAP-72) Solve MUDROD bugs found by sonar coverage

2018-05-17 Thread Yun Li (JIRA)
Yun Li created SDAP-72: -- Summary: Solve MUDROD bugs found by sonar coverage Key: SDAP-72 URL: https://issues.apache.org/jira/browse/SDAP-72 Project: Apache Science Data Analytics Platform Issue Type: