[GitHub] [incubator-sedona] Kimahriman commented on pull request #735: [WIP][SEDONA-212] Rework dependency management

2022-12-22 Thread GitBox
Kimahriman commented on PR #735: URL: https://github.com/apache/incubator-sedona/pull/735#issuecomment-1362871967 Got an initial version of the shaded modules working. Need to see if tests still pass (mostly python ones, using the shaded spark module to run those now). After seeing how

[GitHub] [incubator-sedona] Kimahriman commented on pull request #735: [WIP][SEDONA-212] Rework dependency management

2022-12-19 Thread GitBox
Kimahriman commented on PR #735: URL: https://github.com/apache/incubator-sedona/pull/735#issuecomment-1357614169 > * Dependencies with compile scope are inherited. So python-adapter doesn't need to depend on sql, core and common. Only sql is needed. Same goes for the other modules. Maybe

[GitHub] [incubator-sedona] Kimahriman commented on pull request #735: [WIP][SEDONA-212] Rework dependency management

2022-12-18 Thread GitBox
Kimahriman commented on PR #735: URL: https://github.com/apache/incubator-sedona/pull/735#issuecomment-1356792821 Yeah I think that mostly covers it. We can keep a shaded jar for Spark and/or Flink for people who need it, and that can either be the python-adapter module or a new