RE: Status of SENTRY-1205

2016-06-29 Thread Ma, Junjie
Hello Ashish, Thanks for your review. Currently, for sentry plugin, it won't depend on sentry-service-server which includes about 50 classes. I think SENTRY-1205 is the first step to refactor the module, and I'll improve it according to your evaluation for Kafka plugin later. best regards, Co

Re: Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

2016-06-29 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49397/ --- (Updated June 29, 2016, 11:54 p.m.) Review request for sentry, Anne Yu, Colin M

Re: Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

2016-06-29 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49397/ --- (Updated June 29, 2016, 11:48 p.m.) Review request for sentry, Anne Yu, Colin M

Fwd: Jira maintenance - high priority restart 0100 GMT

2016-06-29 Thread Sravya Tirukkovalur
FYI: Seems like this is the reason jira is unresponsive right now. -- Forwarded message -- From: Chris Lambertus Date: Wed, Jun 29, 2016 at 12:46 PM Subject: Re: Jira maintenance - high priority restart 0100 GMT To: Daniel Gruno Cc: infrastruct...@apache.org > On Jun 29, 2016,

Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

2016-06-29 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49397/ --- Review request for sentry, Anne Yu, Colin McCabe, Hao Hao, and Nachiket Vaidya.

Re: Review Request 49392: SENTRY-1324: Add sentry specific test cases to use NotificationLog using DbNotificationListener

2016-06-29 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49392/ --- (Updated June 29, 2016, 7:56 p.m.) Review request for sentry, Anne Yu, Colin Mc

Review Request 49392: SENTRY-1324: Add sentry specific test cases to use NotificationLog using DbNotificationListener

2016-06-29 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49392/ --- Review request for sentry, Anne Yu, Colin McCabe, and Hao Hao. Bugs: Sentry-132

Re: Status of SENTRY-1205

2016-06-29 Thread Ashish Singh
Hello Junjie, Thanks for the awesome work. I think one of the reasons to have separate server and client packages is to avoid plugins to include lots of dependencies that they do not need. Wondering if you did some evaluation on how this work changes required dependencies for plugins. I am plannin