Re: Review Request 50182: Sentry-1371: Rework Sentry start up and Hive state fetch

2016-07-28 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50182/ --- (Updated July 29, 2016, 1:34 a.m.) Review request for sentry, Anne Yu and Sravy

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-28 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/ --- (Updated July 29, 2016, 12:47 a.m.) Review request for sentry and Sravya Tirukk

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-28 Thread Hao Hao
> On July 28, 2016, 10:18 p.m., Sravya Tirukkovalur wrote: > > Thanks for picking this up Hao! Appreciate it! Do we need to update the non > > pool java clients as well? Yeah, good point. Tend to deprecated non pool java clients in this case. Do you know any reason why we have to keep it? >

Re: Review Request 49777: SENTRY-1321: Implement HMSFollower in Sentry service which reads the NotificationLog entries

2016-07-28 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49777/ --- (Updated July 28, 2016, 11:32 p.m.) Review request for sentry and Hao Hao. Ch

Re: Review Request 49777: SENTRY-1321: Implement HMSFollower in Sentry service which reads the NotificationLog entries

2016-07-28 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49777/#review144020 --- Ship it! Thanks a lot Sravya! +1 with some comments. - Hao Hao

Re: Review Request 49777: SENTRY-1321: Implement HMSFollower in Sentry service which reads the NotificationLog entries

2016-07-28 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49777/#review144009 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-28 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/#review144007 --- Thanks for picking this up Hao! Appreciate it! Do we need to updat

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-28 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/ --- (Updated July 28, 2016, 9:14 p.m.) Review request for sentry and Sravya Tirukko

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-28 Thread Anne Yu
> On July 27, 2016, 9:37 p.m., Rahul Sharma wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java, > > line 47 > > > > > > Are you making that configurable anywhere,

Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-28 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/ --- Review request for sentry and Sravya Tirukkovalur. Repository: sentry Descrip

Re: Review Request 50182: Sentry-1371: Rework Sentry start up and Hive state fetch

2016-07-28 Thread Rahul Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50182/#review143970 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr