Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

2016-10-12 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review152452 --- Ship it! Just one small nit with logging. - Alexander

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

2016-10-12 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review152450 ---

Question about SentryStore/DelegateSentryStore

2016-10-12 Thread Alexander Kolbasov
There is some strangeness in the way SentryStore/DelegateSentryStore is implemented. DelegateSentryStore implements SentryStoreLayer interface, but SentryStore doesn't. It looks like SentryStore should implement this as well. Any thoughts on this?

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

2016-10-12 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review152377 --- Can we add a comment that, this is a workaround until HIVE-14906

Review Request 52795: SENTRY-1499: Add feature flag for using NotificationLog

2016-10-12 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52795/ --- Review request for sentry, Alexander Kolbasov, Anne Yu, Li Li, and Sravya

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

2016-10-12 Thread Li Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review152359 --- Ship it! Ship It! - Li Li On Oct. 12, 2016, 7:15 a.m., Hao

Re: Review Request 52675: Create a sentry scale test tool to add various objects and privileges into Sentry and HMS.

2016-10-12 Thread Li Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52675/#review152274 ---

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

2016-10-12 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/ --- (Updated Oct. 12, 2016, 7:15 a.m.) Review request for sentry, Alexander