Re: Review Request 64317: SENTRY-2085: Keep sentry exceptions contained within Sentry

2017-12-04 Thread Zachary Amsden via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64317/ --- (Updated Dec. 5, 2017, 12:55 a.m.) Review request for sentry and Na Li.

Re: Review Request 64317: SENTRY-2085: Keep sentry exceptions contained within Sentry

2017-12-04 Thread Zachary Amsden via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64317/#review192796 ---

Review Request 64317: SENTRY-2085: Keep sentry exceptions contained within Sentry

2017-12-04 Thread Zachary Amsden via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64317/ --- Review request for sentry and Na Li. Repository: sentry Description ---

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

2017-12-04 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64259/#review192785 --- This project has a lot of command line tools, maybe rename to

[VOTE] Sentry Release 2.0.0 RC3

2017-12-04 Thread Kalyan Kumar Kalvagadda
This is the release of Apache Sentry, version 2.0.0. It fixes the following issues: *https://issues.apache.org/jira/projects/SENTRY/versions/12341081 * Source and bin files https://dist.apache.org/repos/dist/dev/sentry/2.0.0/

[CANCEL][VOTE] Release Sentry version 2.0.0 RC2

2017-12-04 Thread Kalyan Kumar Kalvagadda
Cancelling the vote for 2.0.0 RC2 as an issue has been identified. Binding -1's: Colm O hEigeartaigh I will start voting process for a new candidate. -Kalyan

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

2017-12-04 Thread Na Li via Review Board
> On Dec. 4, 2017, 1 p.m., Colm O hEigeartaigh wrote: > > Why is a new "sentry-main" module needed as part of this fix? because of dependency. If the command is under one of existing directories, it will create circular dependency. That may be why the original code takes that approach

Re: [VOTE] Release Sentry 2.0.0 RC2

2017-12-04 Thread Kalyan Kumar Kalvagadda
Comn, That's the plan. I have gathered list of changes that we need to make to the Wiki page " https://cwiki.apache.org/confluence/display/SENTRY/How+to+Release;. Once the release is done, I will update the page. -Kalyan On Mon, Dec 4, 2017 at 8:30 AM, Colm O hEigeartaigh

Re: [VOTE] Release Sentry 2.0.0 RC2

2017-12-04 Thread Colm O hEigeartaigh
It's a "-1" from me unfortunately, as the source distribution does not build. I've submitted a patch here: https://issues.apache.org/jira/browse/SENTRY-2086 Colm. On Mon, Dec 4, 2017 at 2:30 PM, Colm O hEigeartaigh wrote: > It's a lot easier IMO just letting the Maven

Re: [VOTE] Release Sentry 2.0.0 RC2

2017-12-04 Thread Colm O hEigeartaigh
It's a lot easier IMO just letting the Maven release plugin generate the source + binary distributions. Then all that stuff in the wiki about verifying file names can be removed. Colm, On Mon, Dec 4, 2017 at 2:05 PM, Sergio Pena wrote: > Aaa, thanks. > > I'm a little

Re: [VOTE] Release Sentry 2.0.0 RC2

2017-12-04 Thread Sergio Pena
Aaa, thanks. I'm a little confused about the Wiki now. Last time there were some comments about duplicated .tar.gz files, but the Wiki specifies that we should verify that files are correctly named. Shouldn't we have apache-$project-$version.tar.gz instead to make the release verification easy

Re: [VOTE] Release Sentry 2.0.0 RC2

2017-12-04 Thread Kalyan Kumar Kalvagadda
Sergio, src and bin files are available at https://repository.apache.org/content/repositories/orgapachesentry-1008/org/apache/sentry/sentry-dist/2.0.0/ . If they are extracted we would