Re: Review Request 64317: SENTRY-2085: Keep sentry exceptions contained within Sentry

2017-12-20 Thread Zachary Amsden via Review Board
> On Dec. 19, 2017, 9:26 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java > > Line 837 (original), 837 (patched) > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

2017-12-20 Thread Arjun Mishra via Review Board
> On Dec. 18, 2017, 6:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Line 267 (original), 271 (patched) > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

2017-12-20 Thread Alexander Kolbasov
> On Dec. 18, 2017, 6:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Line 267 (original), 271 (patched) > >

Re: [VOTE] - Release Apache Sentry 1.7.1

2017-12-20 Thread Alexander Kolbasov
+1 On Wed, Dec 20, 2017 at 7:04 AM, Sergio Pena wrote: > Agree. I checked the rest of the release (checksums, gpg, build) and it is > good. > > +1 > > On Wed, Dec 20, 2017 at 2:51 AM Colm O hEigeartaigh > wrote: > > > Yeah I saw that afterwards +

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

2017-12-20 Thread Xinran Tinney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64259/ --- (Updated Dec. 20, 2017, 4:54 p.m.) Review request for sentry, Alexander

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

2017-12-20 Thread Xinran Tinney
> On Dec. 15, 2017, 7:51 p.m., Alexander Kolbasov wrote: > > sentry-command-line-tools/pom.xml > > Lines 47 (patched) > > > > > > You may consider using this instead of the two log4j dependencies. You > > should

Re: [VOTE] - Release Apache Sentry 1.7.1

2017-12-20 Thread Sergio Pena
Agree. I checked the rest of the release (checksums, gpg, build) and it is good. +1 On Wed, Dec 20, 2017 at 2:51 AM Colm O hEigeartaigh wrote: > Yeah I saw that afterwards + updated the branch. I didn't think it was > worthy of cancelling the vote though. What do others

Re: [VOTE] - Release Apache Sentry 1.7.1

2017-12-20 Thread Colm O hEigeartaigh
Yeah I saw that afterwards + updated the branch. I didn't think it was worthy of cancelling the vote though. What do others think? Colm. On Wed, Dec 20, 2017 at 12:29 AM, Sergio Pena wrote: > Colm, the CHANGELOG does not have the 1.7.1 fixes. > Do you need to add