Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-02-08 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/#review197148 ---

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-02-08 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/#review197129 --- I left a few comments, but I need to go early so I would leave

Re: Review Request 65487: Bump com.codahale.metrics package to io.dropwizard.metrics version 3.2.2

2018-02-08 Thread Sergio Pena via Review Board
> On Feb. 8, 2018, 4:13 p.m., Sergio Pena wrote: > > Ship It! Thanks Liam for the patch. I checked that there were no more codehale jars included in the classpath (+1), and that other components, such as Hive, uses the new dropwizard library instead of codehale. So, it makes sense to make

Re: Review Request 65487: Bump com.codahale.metrics package to io.dropwizard.metrics version 3.2.2

2018-02-08 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65487/#review197090 --- Ship it! Ship It! - Sergio Pena On Feb. 2, 2018, 7:31 p.m.,

Re: Review Request 65533: SENTRY-2115: Incorrect behavior of HMsFollower when HDFSSync feature is disabled.

2018-02-08 Thread Sergio Pena via Review Board
> On Feb. 7, 2018, 10:14 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java > > Line 205 (original), 212-213 (patched) > > > >