Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

2017-11-22 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/#review191750 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 63985: SENTRY-2056: Display test-patch.py output on the standard console to see progress on Jenkins

2017-11-22 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63985/ --- (Updated Nov. 22, 2017, 5:29 p.m.) Review request for sentry. Bugs: sentry-20

Re: Review Request 63402: SENTRY-2021 MR session ACLs in Hive binding does not handle all types of ACLs

2017-11-22 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63402/#review191743 --- Ship it! Ship It! - Sergio Pena On Nov. 15, 2017, 9:13 p.m.,

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

2017-11-22 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/#review191739 --- The index for AUTHZ_SNAPSHOT_ID is ok to keep it. If we have multi

Re: Review Request 64002: SENTRY-2068: Disable HTTP TRACE method from the Sentry Web Server

2017-11-22 Thread Sergio Pena via Review Board
> On Nov. 21, 2017, 9:06 p.m., Na Li wrote: > > what test have you done for this update? I added a new patch with the test methods. - Sergio --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64

Re: Review Request 64002: SENTRY-2068: Disable HTTP TRACE method from the Sentry Web Server

2017-11-22 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64002/ --- (Updated Nov. 22, 2017, 3:19 p.m.) Review request for sentry. Changes ---

Re: Review Request 63974: SENTRY-2062: Support the new Hive 2.3.2 DbNotificationListener

2017-11-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63974/ --- (Updated Nov. 21, 2017, 10:14 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

2017-11-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/#review191656 --- Ship it! Ship It! - Sergio Pena On Nov. 21, 2017, 9:27 p.m.,

Review Request 64002: SENTRY-2068: Disable HTTP TRACE method from the Sentry Web Server

2017-11-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64002/ --- Review request for sentry. Bugs: sentry-2068 https://issues.apache.org/jira

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

2017-11-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/#review191636 --- Ship it! Ship It! - Sergio Pena On Nov. 21, 2017, 7:56 p.m.,

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

2017-11-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/#review191619 --- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/te

Re: Review Request 63996: SENTRY-2059: Fix the tests to use transaction listeners for handling HMS Notifications.

2017-11-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63996/#review191617 --- Ship it! Ship It! - Sergio Pena On Nov. 21, 2017, 6:34 p.m.,

Re: Review Request 63402: SENTRY-2021 MR session ACLs in Hive binding does not handle all types of ACLs

2017-11-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63402/#review191581 --- For some reason I cannot see the most updated file nor download it

Review Request 63985: SENTRY-2056: Display test-patch.py output on the standard console to see progress on Jenkins

2017-11-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63985/ --- Review request for sentry. Bugs: sentry-2056 https://issues.apache.org/jira

Review Request 63974: SENTRY-2062: Support the new Hive 2.3.2 DbNotificationListener

2017-11-20 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63974/ --- Review request for sentry. Bugs: sentry-2062 https://issues.apache.org/jira

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

2017-11-20 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/#review191546 --- I see you have different test cases per file and not per method, a

Re: Review Request 63964: SENTRY-2049: Remove hive-authz2 profile from the sentry-dist module

2017-11-20 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63964/#review191545 --- sentry-dist/pom.xml Lines 105-108 (original), 105-108 (patched) <

Review Request 63938: SENTRY-2057: Set hadoop.tmp.dir to the maven build directory configured on java.io.tmpdir

2017-11-18 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63938/ --- Review request for sentry. Bugs: sentry-2057 https://issues.apache.org/jira

Review Request 63928: SENTRY-2054: Unit tests must create temporary files under the Maven target directory

2017-11-17 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63928/ --- Review request for sentry. Bugs: sentry-2054 https://issues.apache.org/jira

Re: Review Request 63896: SENTRY-2052: Reduce TestSentryStore time by setting transaction retries to 1 and other refactors

2017-11-17 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63896/ --- (Updated Nov. 17, 2017, 10:29 p.m.) Review request for sentry. Bugs: sentry-2

Re: Review Request 63896: SENTRY-2052: Reduce TestSentryStore time by setting transaction retries to 1 and other refactors

2017-11-17 Thread Sergio Pena via Review Board
> On Nov. 17, 2017, 5:31 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Line 144 (original), 141 (patched) > >

Re: Review Request 63896: SENTRY-2052: Reduce TestSentryStore time by setting transaction retries to 1 and other refactors

2017-11-17 Thread Sergio Pena via Review Board
> On Nov. 17, 2017, 4:45 p.m., Na Li wrote: > > Have you run the tests for several times to make sure each test cleans up > > the sentry store, so next test won't be affected by previous test state? Yes, I have done that and it works. - Sergio ---

Re: Review Request 63925: SENTRY-1640: Implement HMS Notification barrier on the HMS plugin side

2017-11-17 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63925/ --- (Updated Nov. 17, 2017, 10:04 p.m.) Review request for sentry. Bugs: sentry-1

Review Request 63925: SENTRY-1640: Implement HMS Notification barrier on the HMS plugin side

2017-11-17 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63925/ --- Review request for sentry. Bugs: sentry-1640 https://issues.apache.org/jira

Review Request 63896: SENTRY-2052: Reduce TestSentryStore time by setting transaction retries to 1 and other refactors

2017-11-16 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63896/ --- Review request for sentry. Bugs: sentry-2052 https://issues.apache.org/jira

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

2017-11-16 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/#review191242 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 63856: SENTRY-2048: Bump Hive version to 2.3.2

2017-11-16 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63856/ --- (Updated Nov. 16, 2017, 6:54 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 63856: SENTRY-2048: Bump Hive version to 2.3.2

2017-11-16 Thread Sergio Pena via Review Board
> On Nov. 16, 2017, 3:49 p.m., Na Li wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java > > Lines 382 (patched) > > > > > > is this just tempo

Review Request 63856: SENTRY-2048: Bump Hive version to 2.3.2

2017-11-15 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63856/ --- Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and kalyan k

Re: Review Request 63775: SENTRY-1543 Rename methods to be clearer

2017-11-15 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63775/#review191083 --- The subject of the review board must match the JIRA subject. You c

Re: Review Request 63668: SENTRY-2038 - Some ShellCommand improvements

2017-11-15 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63668/#review191082 --- Ship it! Ship It! - Sergio Pena On Nov. 15, 2017, 11:04 a.m.

Re: Review Request 63668: SENTRY-2038 - Some ShellCommand improvements

2017-11-14 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63668/#review191000 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 63402: SENTRY-2021 MR session ACLs in Hive binding does not handle all types of ACLs

2017-11-14 Thread Sergio Pena via Review Board
> On Nov. 14, 2017, 8:19 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingSessionHook.java > > Lines 116-117 (original), 116-122 (patched) > > >

Re: Review Request 63402: SENTRY-2021 MR session ACLs in Hive binding does not handle all types of ACLs

2017-11-14 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63402/#review190997 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/ --- (Updated Nov. 13, 2017, 5:12 p.m.) Review request for sentry. Changes ---

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-09 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/ --- (Updated Nov. 9, 2017, 11:44 p.m.) Review request for sentry. Bugs: sentry-20

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-09 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/ --- (Updated Nov. 9, 2017, 6:51 p.m.) Review request for sentry. Bugs: sentry-203

Re: Review Request 63335: SENTRY-2018: Remove SentryMetastorePostEventListener and SentryMetastorePostEventListenerBase classes

2017-11-09 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63335/#review190624 --- Ship it! Ship It! - Sergio Pena On Nov. 9, 2017, 2:58 p.m.,

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-09 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/ --- (Updated Nov. 9, 2017, 4:34 p.m.) Review request for sentry. Changes ---

Re: Review Request 63667: SENTRY-2037: Remove not needed sentry-binding-hive-v2 dependency from the main pom.xml

2017-11-09 Thread Sergio Pena via Review Board
> On Nov. 9, 2017, 4:18 p.m., Na Li wrote: > > should we remove the definition of profile hive-authz2 as well? Not yet. The idea is to keep this profile for a little while until we make sure the transition is completely (without issues). There is still code and tests that could have been forgo

Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-08 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/ --- Review request for sentry. Bugs: sentry-2039 https://issues.apache.org/jira

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

2017-11-08 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/#review190473 --- pom.xml Line 94 (original), 94 (patched)

Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

2017-11-08 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63647/#review190472 --- Ship it! Ship It! - Sergio Pena On Nov. 7, 2017, 9:58 p.m.,

Review Request 63667: SENTRY-2037: Remove not needed sentry-binding-hive-v2 dependency from the main pom.xml

2017-11-08 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63667/ --- Review request for sentry. Bugs: sentry-2037 https://issues.apache.org/jira

Re: Review Request 63646: SENTRY-2035: Metrics should move to destination atomically

2017-11-07 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63646/#review190374 --- Ship it! Ship It! - Sergio Pena On Nov. 7, 2017, 9:47 p.m.,

Re: Review Request 63619: SENTRY-2033: Fix TestDbPrivilegeCleanupOnDrop to use SentryMetastorePostEventListenerNotificationLog

2017-11-07 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63619/#review190369 --- Ship it! Ship It! - Sergio Pena On Nov. 7, 2017, 6:17 p.m.,

Re: Review Request 63619: SENTRY-2033: Fix TestDbPrivilegeCleanupOnDrop to use SentryMetastorePostEventListenerNotificationLog

2017-11-07 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63619/#review190337 --- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/te

Re: Review Request 63518: SENTRY-1997 - "Bump sqoop dependency version to 1.99.7"

2017-11-07 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63518/#review190336 --- Ship it! Looks good. I see only tests are modified to make it w

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

2017-11-07 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/#review190334 --- Let's not commit this yet until we understand why AUTHZ_OBJ_NAME i

Re: Review Request 63509: SENTRY-2028: Avoid datanucleus to create/update database schema

2017-11-06 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63509/#review190171 --- Ship it! Ship It! - Sergio Pena On Nov. 3, 2017, 10:52 p.m.,

Re: Review Request 63433: SENTRY-2026: Bump Hadoop version from 2.7.2 to 2.7.4

2017-10-31 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63433/#review189745 --- Ship it! Ship It! - Sergio Pena On Oct. 30, 2017, 11:15 p.m.

Re: Review Request 63308: SENTRY-2020: Fix testConsumeCycleWithInsufficientPrivileges test failure in kafka e2e tests.

2017-10-26 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63308/#review189319 --- Ship it! Ship It! - Sergio Pena On Oct. 26, 2017, 5:26 p.m.,

Re: Review Request 63309: SENTRY-2017: Fix Sentry e2e tests to use SentryMetastorePostEventListenerNotificationLog

2017-10-26 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63309/#review189301 --- Ship it! Ship It! - Sergio Pena On Oct. 26, 2017, 2:03 p.m.,

Re: Review Request 63308: SENTRY-2020: Fix testConsumeCycleWithInsufficientPrivileges test failure in kafka e2e tests.

2017-10-26 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63308/#review189300 --- sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/t

Re: Review Request 63303: SENTRY-1992 Improve parameter handling for SentryGenericProviderBackend

2017-10-26 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63303/#review189295 --- Ship it! Ship It! - Sergio Pena On Oct. 25, 2017, 7:01 p.m.,

Re: Review Request 63215: SENTRY-2015 - Refactor Command implementations

2017-10-24 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63215/#review189104 --- Ship it! The patch looks good. +1 - Sergio Pena On Oct. 23,

Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library

2017-10-22 Thread Sergio Pena via Review Board
> On Oct. 22, 2017, 10:12 a.m., Colm O hEigeartaigh wrote: > > Is the indentation change to > > "sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provide > > r/db/service/thrift/TestSentryWebServerWithKerberos.java" intentional? It is not. I accidentally left those spaces. I

Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library

2017-10-22 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63160/ --- (Updated Oct. 22, 2017, 3:27 p.m.) Review request for sentry. Changes ---

Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library

2017-10-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63160/ --- (Updated Oct. 22, 2017, 3:10 a.m.) Review request for sentry. Bugs: sentry-16

Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library

2017-10-21 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63160/ --- (Updated Oct. 22, 2017, 3:09 a.m.) Review request for sentry. Changes ---

Re: Review Request 63178: SENTRY-1989: Bump Kafka version from 0.9 to 0.11

2017-10-20 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63178/#review188842 --- Ship it! Ship It! - Sergio Pena On Oct. 20, 2017, 12:41 p.m.

Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library

2017-10-20 Thread Sergio Pena via Review Board
> On Oct. 19, 2017, 7:25 p.m., kalyan kumar kalvagadda wrote: > > I'm fine with bumping up the jetty version but the only concern is that the > > Solr tests will be failing unitl changes for SENTRY-1475 are committed. > > Colm O hEigeartaigh wrote: > Agreed, probably best waiting until the

Review Request 63160: SENTRY-1667: Switching to Jetty v9 library

2017-10-19 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63160/ --- Review request for sentry. Bugs: sentry-1667 https://issues.apache.org/jira

Re: Review Request 63086: SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java

2017-10-18 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63086/#review188491 --- Ship it! Ship It! - Sergio Pena On Oct. 17, 2017, 7:12 p.m.,

Re: Review Request 63046: SENTRY-1980: Move the hive-authz2 HMS client filtering implementation into the sentry-binding-hive module

2017-10-17 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63046/ --- (Updated Oct. 17, 2017, 7:11 p.m.) Review request for sentry, Alexander Kolbaso

Review Request 63048: SENTRY-1995: Bump Derby dependency version to 10.13.1.1

2017-10-16 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63048/ --- Review request for sentry. Bugs: sentry-1995 https://issues.apache.org/jira

Review Request 63047: SENTRY-1994: Bump Shiro dependency version to 1.4.0

2017-10-16 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63047/ --- Review request for sentry. Bugs: sentry-1994 https://issues.apache.org/jira

Review Request 63046: SENTRY-1980: Move the hive-authz2 HMS client filtering implementation into the sentry-binding-hive module

2017-10-16 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63046/ --- Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and kalyan k

Re: Review Request 63026: SENTRY-1979 - Consolidate code for converting Hive privilege objects to Strings

2017-10-16 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63026/#review188184 --- Ship it! Patch looks good. - Sergio Pena On Oct. 16, 2017, 1

Re: Review Request 62951: SENTRY-1231: Sentry doesn't secure index location uri, when do "CREATE INDEX LOCATION ''/uri"

2017-10-16 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62951/ --- (Updated Oct. 16, 2017, 6:34 p.m.) Review request for sentry and kalyan kumar k

Re: Review Request 62979: SENTRY-1985: Sentry should log in stdout when it is ready to serve requests

2017-10-16 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62979/ --- (Updated Oct. 16, 2017, 3:35 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 62979: SENTRY-1985: Sentry should log in stdout when it is ready to serve requests

2017-10-16 Thread Sergio Pena via Review Board
> On Oct. 13, 2017, 4:39 p.m., Na Li wrote: > > should SentryService log the sentry service is ready? You only logged > > HMSFollower is ready In order to figure out the service is ready than we need to do it on the HMSFollower because it needs to know when it finishes getting an snapshot. -

Review Request 62992: SENTRY-1990: Use same hadoop.version to hadoop-aws dependencies

2017-10-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62992/ --- Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Na L

Re: Review Request 62902: SENTRY-1978: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

2017-10-13 Thread Sergio Pena via Review Board
> On Oct. 13, 2017, 9:09 p.m., Na Li wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/util/SentryAuthorizerUtil.java > > Lines 129 (patched) > > > > > > Can you add the following

Re: Review Request 62902: SENTRY-1978: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

2017-10-13 Thread Sergio Pena via Review Board
> On Oct. 13, 2017, 8:57 p.m., Na Li wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerImpl.java > > Line 52 (original), 64 (patched) > > > > > > shou

Review Request 62990: SENTRY-1988: Bump slf4j version from 1.6.0 to 1.7.25 (latest version)

2017-10-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62990/ --- Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Na L

Review Request 62987: SENTRY-1987: Remove pom code related to non-existing TestSentryAuthorizationProvider class

2017-10-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62987/ --- Review request for sentry, Alexander Kolbasov and kalyan kumar kalvagadda. Bugs

Re: Review Request 62942: Bump the minimum java version to 8

2017-10-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62942/ --- (Updated Oct. 13, 2017, 6:30 p.m.) Review request for sentry, Alexander Kolbaso

Review Request 62983: SENTRY-1986: Fix NPE on createGrantTask from SentryHiveAuthorizationTaskFactoryImpl.java

2017-10-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62983/ --- Review request for sentry and kalyan kumar kalvagadda. Bugs: sentry-1986 ht

Review Request 62979: SENTRY-1985: Sentry should log in stdout when it is ready to serve requests

2017-10-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62979/ --- Review request for sentry, Alexander Kolbasov and kalyan kumar kalvagadda. Bugs

Review Request 62977: SENTRY-1984: Decrease number of max idle connections for Sentry clients

2017-10-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62977/ --- Review request for sentry, Alexander Kolbasov and kalyan kumar kalvagadda. Bugs

Review Request 62953: SENTRY-1983: Several commit/rollback errors happen in oracle12c-r1 due to current isolation level

2017-10-12 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62953/ --- Review request for sentry and Alexander Kolbasov. Bugs: sentry-1983 https:/

Review Request 62951: SENTRY-1231: Sentry doesn't secure index location uri, when do "CREATE INDEX LOCATION ''/uri"

2017-10-12 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62951/ --- Review request for sentry and kalyan kumar kalvagadda. Bugs: sentry-1231 ht

Review Request 62950: SENTRY-1981: Bump codehale metrics version to latest 3.0.2 version

2017-10-12 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62950/ --- Review request for sentry, Alexander Kolbasov and kalyan kumar kalvagadda. Bugs

Re: Review Request 62812: SENTRY-1975 - Add sqoop support to SentryShellGeneric

2017-10-12 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62812/#review187851 --- Ship it! The patchs looks good. +1 - Sergio Pena On Oct. 6,

Re: Review Request 62902: SENTRY-1978: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

2017-10-12 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62902/ --- (Updated Oct. 12, 2017, 7:35 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 62942: Bump the minimum java version to 8

2017-10-12 Thread Sergio Pena via Review Board
> On Oct. 12, 2017, 6:56 p.m., Alexander Kolbasov wrote: > > You also need to update version for com.google.errorprone I left a comment on the jira about it. I couldn't bump the google_error_prone dependency to any one that uses Java8 because it was causing IncompatibleClassChangeError when cl

Review Request 62942: Bump the minimum java version to 8

2017-10-12 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62942/ --- Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and kalyan k

Review Request 62902: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

2017-10-11 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62902/ --- Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and kalyan k

<    1   2   3   4