Re: Review Request 66748: Refactor out Sentry CLI from sentry-provider-db into own module

2018-04-23 Thread Steve Moist via Review Board
> On April 23, 2018, 4:34 p.m., Colm O hEigeartaigh wrote: > > Shouldn't the location of the files be changed as well? If I apply the diff > > from this JIRA I see, for example: > > > > ./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/ShellCommand.java > >

Re: Review Request 66748: Refactor out Sentry CLI from sentry-provider-db into own module

2018-04-23 Thread Steve Moist via Review Board
> On April 23, 2018, 4:34 p.m., Colm O hEigeartaigh wrote: > > Shouldn't the location of the files be changed as well? If I apply the diff > > from this JIRA I see, for example: > > > > ./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/ShellCommand.java > >

Re: Review Request 66748: Refactor out Sentry CLI from sentry-provider-db into own module

2018-04-23 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66748/#review201745 --- Shouldn't the location of the files be changed as well? If I