Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

> On June 25, 2018, 4:23 p.m., Fahd Siddiqui wrote: > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java > > Line 52 (original), 52 (patched) > > > > > > It did cause

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/#review205297 --- Ship it! Ship It! - kalyan kumar kalvagadda On June 22,

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

> On June 25, 2018, 4:23 p.m., Fahd Siddiqui wrote: > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java > > Line 52 (original), 52 (patched) > > > > > > It did cause

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

> On June 25, 2018, 3:28 p.m., kalyan kumar kalvagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java > > Line 52 (original), 52 (patched) > > > > > > How

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/#review205294 ---

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/#review205290 ---

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/#review205240 --- Ship it! Looks Good. - kalyan kumar kalvagadda On June 22,

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

> On June 20, 2018, 4:42 p.m., kalyan kumar kalvagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/classification/InterfaceAudience.java > > Lines 30-35 (patched) > >

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/ --- (Updated June 22, 2018, 4:31 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

> On June 20, 2018, 4:32 p.m., kalyan kumar kalvagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java > > Lines 57-81 (patched) > >

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

> On June 20, 2018, 4:32 p.m., kalyan kumar kalvagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java > > Lines 57-81 (patched) > >

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

> On June 20, 2018, 4:32 p.m., kalyan kumar kalvagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java > > Lines 51-52 (patched) > >

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

> On June 20, 2018, 4:42 p.m., kalyan kumar kalvagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/classification/InterfaceAudience.java > > Lines 37-45 (patched) > >

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/#review205095 ---

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/#review205093 --- Fix it