Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-12-12 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review211255 --- Also test case to cover case when an object already exist and we

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-12-12 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review211254 ---

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-12-12 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review211251 --- Kalyan,we need to persist MAuthzPathsMapping object at the end

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-12-12 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review211248 --- Fix it, then Ship it!

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-12-11 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review211198 --- Ship it! Ship It! - Arjun Mishra On Nov. 29, 2018, 10:14

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-12-11 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review211191 --- Ship it! Ship It! - Sergio Pena On Nov. 29, 2018, 10:14

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-12-10 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review211169 --- Ship it! Ship It! - Na Li On Nov. 29, 2018, 10:14 p.m.,

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-30 Thread Na Li via Review Board
> On Nov. 29, 2018, 6:44 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Lines 176 (patched) > > > > > > do you want

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-29 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/ --- (Updated Nov. 29, 2018, 10:14 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-29 Thread kalyan kumar kalvagadda via Review Board
> On Nov. 29, 2018, 6:44 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Lines 176 (patched) > > > > > > do you want

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-29 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210950 ---

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-29 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/ --- (Updated Nov. 29, 2018, 6:32 p.m.) Review request for sentry, Arjun Mishra, Na

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-29 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/ --- (Updated Nov. 29, 2018, 6:29 p.m.) Review request for sentry, Arjun Mishra, Na

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-29 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210949 ---

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-21 Thread kalyan kumar kalvagadda via Review Board
> On Nov. 20, 2018, 5:20 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Line 36 (original), 45 (patched) > > > > > >

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-21 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/ --- (Updated Nov. 21, 2018, 7:48 p.m.) Review request for sentry, Arjun Mishra, Na

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-20 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210731 ---

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-20 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210730 ---

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-20 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210728 ---

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-20 Thread Na Li via Review Board
> On Nov. 20, 2018, 5:08 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Lines 179 (patched) > > > > > > can you set

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-16 Thread kalyan kumar kalvagadda via Review Board
> On Nov. 1, 2018, 1:35 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Lines 37 (patched) > > > > > > This is

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-01 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210252 ---

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-10-31 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/ --- (Updated Oct. 31, 2018, 11:28 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-10-31 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210228 ---

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-10-31 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/ --- (Updated Oct. 31, 2018, 12:58 p.m.) Review request for sentry, Arjun Mishra,